From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CFD071FF17C for ; Wed, 20 Aug 2025 11:11:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A90C9362FE; Wed, 20 Aug 2025 11:13:35 +0200 (CEST) Message-ID: <3518c038-8cbf-4df8-a752-54570d1b22bb@proxmox.com> Date: Wed, 20 Aug 2025 11:13:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Datacenter Manager development discussion , Stefan Hanreich References: <20250819132538.223207-1-s.hanreich@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20250819132538.223207-1-s.hanreich@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755681138584 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [column.rs] Subject: Re: [pdm-devel] [PATCH proxmox-yew-widget-toolkit 1/1] data table: add get_property helper for displaying optional values X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" wouldn't it also be possible to simply unwrap the option on the source side? e.g. for a string ... .get_property(|rec: &Record| rec.option.as_deref().unwrap_or("")) ``` ? of course you can always implement the renderer and sorter yourself (which should only be a single line each if the value has Display + Ord) in general I'm not sure we want to show None values as nothing, this largely depends on the data (e.g. valid things to show/expect could be '-', 'N/A', etc.) Also one comment inline On 8/19/25 15:25, Stefan Hanreich wrote: > In some cases, particularly for tree views, it might make sense to not > show values for some cells. In order to simplify handling optional > values, add a get_property helper that can work with optional values. > It renders the values if it exists and nothing otherwise. Since Option > implements Ord, the widget can use its Ord implementation for sorting. > The current helpers cannot be used, since Option does not implement > Display, so the trait bounds are not satisfied. > > Signed-off-by: Stefan Hanreich > --- > src/widget/data_table/column.rs | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/src/widget/data_table/column.rs b/src/widget/data_table/column.rs > index 016be99..770d7c7 100644 > --- a/src/widget/data_table/column.rs > +++ b/src/widget/data_table/column.rs > @@ -5,7 +5,7 @@ use derivative::Derivative; > use yew::html::IntoPropValue; > use yew::prelude::*; > > -use yew::virtual_dom::Key; > +use yew::virtual_dom::{Key, VNode}; > > use crate::props::{CallbackMut, IntoEventCallbackMut, IntoSorterFn, RenderFn, SorterFn}; > use crate::state::TreeStore; > @@ -328,6 +328,22 @@ impl DataTableColumn { > .render(move |item: &T| html! {{get_property_fn(item)}}) > } > > + /// Builder style method to set a get_property_fn for renderer and sorter > + /// the given fn must return the value as an Option > + pub fn get_property_optional( > + self, > + get_property_fn: impl 'static + Fn(&T) -> Option<&E>, > + ) -> Self { > + let get_property_fn = Rc::new(get_property_fn); > + self.sorter({ > + let get_property_fn = get_property_fn.clone(); > + move |itema: &T, itemb: &T| get_property_fn(itema).cmp(&get_property_fn(itemb)) > + }) > + .render( > + move |item: &T| html! {{get_property_fn(item).map(VNode::from).unwrap_or_default()}}, mhmm since we require the Display trait as boundary, wouldn't a to_string() be better here? The default for VNode is a VList, but an empty string produces a VText > + ) > + } > + > /// Builder style method for [`Self::set_tree_column`] > pub fn tree_column(mut self, store: impl IntoPropValue>>) -> Self { > self.set_tree_column(store); _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel