From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8CF9A1FF162 for <inbox@lore.proxmox.com>; Mon, 5 May 2025 16:51:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A12981FF6E; Mon, 5 May 2025 16:51:52 +0200 (CEST) Date: Mon, 5 May 2025 16:51:48 +0200 From: Wolfgang Bumiller <w.bumiller@proxmox.com> To: Daniel Kral <d.kral@proxmox.com> Message-ID: <34ne6csctoxhbdjt5keirw53lxjrjuhu23zmezbcvvhc34tt25@yirnz2u373gd> References: <20250415135045.255272-1-d.kral@proxmox.com> <20250415135045.255272-4-d.kral@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250415135045.255272-4-d.kral@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage v3 3/4] vdisk_alloc: factor out optional parameters in options hash argument X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: pve-devel@lists.proxmox.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> T24gVHVlLCBBcHIgMTUsIDIwMjUgYXQgMDM6NTA6MjFQTSArMDIwMCwgRGFuaWVsIEtyYWwgd3Jv dGU6Cj4gTW92ZSB0aGUgb3B0aW9uYWwgcGFyYW1ldGVyIGBuYW1lYCBpbnRvIGFuIG9wdGlvbmFs IGhhc2ggYXJndW1lbnQgYXQgdGhlCj4gZW5kIG9mIHRoZSBzdWJyb3V0aW5lIHNpZ25hdHVyZSBv ZiB2ZGlza19hbGxvYygpLgo+IAo+IFRoaXMgYWxsb3dzIHRvIGFkZCBtb3JlIG9wdGlvbmFsIGFy Z3VtZW50cyBpbiB0aGUgZnV0dXJlIGFuZCBtYWtlcyB0aGUKPiBmdW5jdGlvbiBjYWxsIGVhc2ll ciB0byBmb2xsb3cgd2hlbiBhIG5hbWUgaXMgbm90IHJlcXVpcmVkLgo+IAo+IFRoaXMgcmVxdWly ZXMgYSB2ZXJzaW9uZWQgYnJlYWsgZm9yIHBhY2thZ2VzIHRoYXQgY2FsbCB2ZGlza19hbGxvYygp LAo+IHdoaWNoIGFyZSBjdXJyZW50bHkgcWVtdS1zZXJ2ZXIgYW5kIHB2ZS1jb250YWluZXIuCj4g Cj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIEtyYWwgPGQua3JhbEBwcm94bW94LmNvbT4KPiAtLS0K PiBjaGFuZ2VzIHNpbmNlIHYyOgo+ICAgKiB3cmFwIDEwMCsgY2hhciBsaW5lcyBjb3JyZWN0bHkK PiAgICogYWRkICRmbXQgYmFjayBhcyBhIHJlcXVpcmVkIHBhcmFtZXRlciBhcyBpdCBkaWRuJ3Qg bWFrZSBzZW5zZSB0bwo+ICAgICBoYXZlIGl0IGJlIG9wdGlvbmFsIGJlY2F1c2Ugb2Ygb25seSBh IGZldyBwbGFjZXMKPiAKPiAgc3JjL1BWRS9BUEkyL1N0b3JhZ2UvQ29udGVudC5wbSAgICB8ICA1 ICsrLS0tCj4gIHNyYy9QVkUvR3Vlc3RJbXBvcnQucG0gICAgICAgICAgICAgfCAgMiArLQo+ICBz cmMvUFZFL1N0b3JhZ2UucG0gICAgICAgICAgICAgICAgIHwgMzIgKysrKysrKysrKysrKysrKysr KysrKysrKysrKy0tCj4gIHNyYy90ZXN0L3J1bl90ZXN0X3pmc3Bvb2xwbHVnaW4ucGwgfCAgOCAr KysrLS0tLQo+ICA0IGZpbGVzIGNoYW5nZWQsIDM3IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9u cygtKQo+IAo+IGRpZmYgLS1naXQgYS9zcmMvUFZFL0FQSTIvU3RvcmFnZS9Db250ZW50LnBtIGIv c3JjL1BWRS9BUEkyL1N0b3JhZ2UvQ29udGVudC5wbQo+IGluZGV4IDhmYmZiZTkuLjY0ZWQ1NmQg MTAwNjQ0Cj4gLS0tIGEvc3JjL1BWRS9BUEkyL1N0b3JhZ2UvQ29udGVudC5wbQo+ICsrKyBiL3Ny Yy9QVkUvQVBJMi9TdG9yYWdlL0NvbnRlbnQucG0KPiBAQCAtMjE4LDkgKzIxOCw4IEBAIF9fUEFD S0FHRV9fLT5yZWdpc3Rlcl9tZXRob2QgKHsKPiAgCj4gIAlteSAkY2ZnID0gUFZFOjpTdG9yYWdl Ojpjb25maWcoKTsKPiAgCj4gLQlteSAkdm9saWQgPSBQVkU6OlN0b3JhZ2U6OnZkaXNrX2FsbG9j ICgkY2ZnLCAkc3RvcmVpZCwgJHBhcmFtLT57dm1pZH0sCj4gLQkJCQkJICAgICAgICRwYXJhbS0+ e2Zvcm1hdH0sCj4gLQkJCQkJICAgICAgICRuYW1lLCAkc2l6ZSk7Cj4gKwlteSAkdm9saWQgPSBQ VkU6OlN0b3JhZ2U6OnZkaXNrX2FsbG9jKAo+ICsJICAgICRjZmcsICRzdG9yZWlkLCAkcGFyYW0t Pnt2bWlkfSwgJHBhcmFtLT57Zm9ybWF0fSwgJHNpemUsIHsgbmFtZSA9PiAkbmFtZSB9KTsKCuKG kSBIZXJlIG9wdHMgaXMgYSByZWZlcmVuY2UgKGlvdy4gYSBzY2FsYXIsIGFzIGluIGAkb3B0c2As IG5vdCBgJW9wdHNgKS4KCj4gIAo+ICAJcmV0dXJuICR2b2xpZDsKPiAgICAgIH19KTsKPiBkaWZm IC0tZ2l0IGEvc3JjL1BWRS9HdWVzdEltcG9ydC5wbSBiL3NyYy9QVkUvR3Vlc3RJbXBvcnQucG0K PiBpbmRleCAxNjA5OWNhLi43NmViYzlkIDEwMDY0NAo+IC0tLSBhL3NyYy9QVkUvR3Vlc3RJbXBv cnQucG0KPiArKysgYi9zcmMvUFZFL0d1ZXN0SW1wb3J0LnBtCj4gQEAgLTY5LDcgKzY5LDcgQEAg c3ViIGV4dHJhY3RfZGlza19mcm9tX2ltcG9ydF9maWxlIHsKPiAgCj4gIAkjIGNyZWF0ZSB0ZW1w b3JhcnkgMU0gaW1hZ2UgdGhhdCB3aWxsIGdldCBvdmVyd3JpdHRlbiBieSB0aGUgcmVuYW1lCj4g IAkjIHRvIHJlc2VydmUgdGhlIGZpbGVuYW1lIGFuZCB0YWtlIGNhcmUgb2YgbG9ja2luZwo+IC0J JHRhcmdldF92b2xpZCA9IFBWRTo6U3RvcmFnZTo6dmRpc2tfYWxsb2MoJGNmZywgJHRhcmdldF9z dG9yZWlkLCAkdm1pZCwgJGlubmVyX2ZtdCwgdW5kZWYsIDEwMjQpOwo+ICsJJHRhcmdldF92b2xp ZCA9IFBWRTo6U3RvcmFnZTo6dmRpc2tfYWxsb2MoJGNmZywgJHRhcmdldF9zdG9yZWlkLCAkdm1p ZCwgJGlubmVyX2ZtdCwgMTAyNCk7Cj4gIAkkdGFyZ2V0X3BhdGggPSBQVkU6OlN0b3JhZ2U6OnBh dGgoJGNmZywgJHRhcmdldF92b2xpZCk7Cj4gIAo+ICAJcHJpbnQgInJlbmFtaW5nICRzb3VyY2Vf cGF0aCB0byAkdGFyZ2V0X3BhdGhcbiI7Cj4gZGlmZiAtLWdpdCBhL3NyYy9QVkUvU3RvcmFnZS5w bSBiL3NyYy9QVkUvU3RvcmFnZS5wbQo+IGluZGV4IGVlYTUxZTkuLmFiNGRjZGQgMTAwNzU1Cj4g LS0tIGEvc3JjL1BWRS9TdG9yYWdlLnBtCj4gKysrIGIvc3JjL1BWRS9TdG9yYWdlLnBtCj4gQEAg LTEwNTYsOCArMTA1NiwzNiBAQCBzdWIgdW5tYXBfdm9sdW1lIHsKPiAgICAgIHJldHVybiAkcGx1 Z2luLT51bm1hcF92b2x1bWUoJHN0b3JlaWQsICRzY2ZnLCAkdm9sbmFtZSwgJHNuYXBuYW1lKTsK PiAgfQo+ICAKPiAtc3ViIHZkaXNrX2FsbG9jIHsKPiAtICAgIG15ICgkY2ZnLCAkc3RvcmVpZCwg JHZtaWQsICRmbXQsICRuYW1lLCAkc2l6ZSkgPSBAXzsKPiArPWhlYWQzIHZkaXNrX2FsbG9jKCRj ZmcsICRzdG9yZWlkLCAkdm1pZCwgJGZtdCwgJHNpemUgWywgJW9wdHNdKQoK4oaRIEhlcmUgeW91 IGRvY3VtZW50IGl0IGFzIGFuIGlubGluZSBoYXNoLgoKPiArCj4gK0FsbG9jYXRlcyBhIHZvbHVt ZSBvbiB0aGUgc3RvcmFnZSB3aXRoIHRoZSBpZGVudGlmaWVyIEM8JHN0b3JlaWQ+IChkZWZpbmVk IGluCj4gK3RoZSBzdG9yYWdlIGNvbmZpZyBDPCRjZmc+KSBmb3IgdGhlIFZNIHdpdGggdGhlIGlk IEM8JHZtaWQ+IHdpdGggZm9ybWF0IEM8JGZtdD4KPiArYW5kIGEgc2l6ZSBvZiBDPCRzaXplPiBr aWxvYnl0ZXMuCj4gKwo+ICtUaGUgZm9ybWF0IEM8JGZtdD4gY2FuIGJlIEM8J3Jhdyc+LCBDPCdx Y293Mic+LCBDPCdzdWJ2b2wnPiBvciBDPCd2bWRrJz4uIElmCj4gK0M8JGZtdD4gaXMgbGVmdCB1 bmRlZmluZWQsIGl0IHdpbGwgZmFsbGJhY2sgb24gdGhlIGRlZmF1bHQgZm9ybWF0IG9mIHRoZSBz dG9yYWdlCj4gK3R5cGUgb2YgQzwkc3RvcmVpZD4uCj4gKwo+ICtPcHRpb25hbGx5LCB0aGUgZm9s bG93aW5nIGtleS12YWx1ZSBwYWlycyBhcmUgYXZhaWxhYmxlIGZvciBDPCVvcHRzPjoKPiArCj4g Kz1vdmVyCj4gKwo+ICs9aXRlbSAqIEM8PCAkbmFtZSA9PiAkc3RyaW5nID4+Cj4gKwo+ICtTcGVj aWZpZXMgdGhlIG5hbWUgb2YgdGhlIG5ldyB2b2x1bWUuCj4gKwo+ICtJZiB1bmRlZmluZWQsIHRo ZSBuYW1lIHdpbGwgYmUgYXV0b21hdGljYWxseSBnZW5lcmF0ZWQuCj4gKwo+ICs9YmFjawo+ICsK PiArUmV0dXJucyB0aGUgaWRlbnRpZmllciBmb3IgdGhlIG5ldyB2b2x1bWUgaW4gdGhlIGZvcm1h dCBDPCIkc3RvcmVpZDokdm9sbmFtZSI+Lgo+ICsKPiArPWN1dAo+ICsKPiArc3ViIHZkaXNrX2Fs bG9jIDogcHJvdG90eXBlKCQkJCQkOyUpIHsKPiArICAgIG15ICgkY2ZnLCAkc3RvcmVpZCwgJHZt aWQsICRmbXQsICRzaXplLCAkb3B0cykgPSBAXzsKCuKGkSBIZXJlIHlvdSB1c2UgJSBmb3IgdGhl IHByb3RvdHlwZSwgYnV0ICQgZm9yIHRoZSBwYXJhbWV0ZXIuCgpZb3UgbmVlZCB0byBzdGljayB3 aXRoIG9uZSB2YXJpYW50LiA7LSkKCihUaGVzZSBkYXlzLCBwZXJzb25hbGx5IEknZCBnbyBmb3Ig YSByZWZlcmVuY2UgKCQpLCBzaW5jZSB3ZSB1c2UgJQpyYXJlbHksIGFuZCBpdCdzIGEgbmljZXIg c2VwYXJhdGlvbiBmcm9tIHRoZSB1bm5hbWVkIHBhcmFtZXRlcnMgSU1PLi4uKQoKPiArCj4gKyAg ICBteSAkbmFtZSA9ICRvcHRzLT57bmFtZX07Cj4gIAo+ICAgICAgZGllICJubyBzdG9yYWdlIElE IHNwZWNpZmllZFxuIiBpZiAhJHN0b3JlaWQ7Cj4gIAo+IGRpZmYgLS1naXQgYS9zcmMvdGVzdC9y dW5fdGVzdF96ZnNwb29scGx1Z2luLnBsIGIvc3JjL3Rlc3QvcnVuX3Rlc3RfemZzcG9vbHBsdWdp bi5wbAo+IGluZGV4IDA5NWNjYjMuLjdkZDBhMmIgMTAwNzU1Cj4gLS0tIGEvc3JjL3Rlc3QvcnVu X3Rlc3RfemZzcG9vbHBsdWdpbi5wbAo+ICsrKyBiL3NyYy90ZXN0L3J1bl90ZXN0X3pmc3Bvb2xw bHVnaW4ucGwKPiBAQCAtNTY1LDcgKzU2NSw3IEBAIG15ICR0ZXN0MTMgPSBzdWIgewo+ICAgICAg cHJpbnQgIlxucnVuIHRlc3QxMyBcInZkaXNrX2FsbG9jXCJcbiI7Cj4gIAo+ICAgICAgZXZhbCB7 Cj4gLQlteSAkdG1wX3ZvbGlkID0gUFZFOjpTdG9yYWdlOjp2ZGlza19hbGxvYygkY2ZnLCAkc3Rv cmFnZW5hbWUsICIxMTIiLCAicmF3IiwgdW5kZWYgLDEwMjQgKiAxMDI0KTsKPiArCW15ICR0bXBf dm9saWQgPSBQVkU6OlN0b3JhZ2U6OnZkaXNrX2FsbG9jKCRjZmcsICRzdG9yYWdlbmFtZSwgIjEx MiIsICJyYXciLCAxMDI0ICogMTAyNCk7Cj4gIAo+ICAJaWYgKCR0bXBfdm9saWQgbmUgIiRzdG9y YWdlbmFtZTp2bS0xMTItZGlzay0wIikgewo+ICAJICAgIGRpZSAidm9sbmFtZTokdG1wX3ZvbGlk IGRvbid0IG1hdGNoXG4iOwo+IEBAIC01ODksNyArNTg5LDcgQEAgbXkgJHRlc3QxMyA9IHN1YiB7 Cj4gICAgICB9Cj4gIAo+ICAgICAgZXZhbCB7Cj4gLQlteSAkdG1wX3ZvbGlkID0gUFZFOjpTdG9y YWdlOjp2ZGlza19hbGxvYygkY2ZnLCAkc3RvcmFnZW5hbWUsICIxMTIiLCAicmF3IiwgdW5kZWYg LDIwNDggKiAxMDI0KTsKPiArCW15ICR0bXBfdm9saWQgPSBQVkU6OlN0b3JhZ2U6OnZkaXNrX2Fs bG9jKCRjZmcsICRzdG9yYWdlbmFtZSwgIjExMiIsICJyYXciLCAyMDQ4ICogMTAyNCk7Cj4gIAo+ ICAJaWYgKCR0bXBfdm9saWQgbmUgIiRzdG9yYWdlbmFtZTp2bS0xMTItZGlzay0xIikgewo+ICAJ ICAgIGRpZSAidm9sbmFtZTokdG1wX3ZvbGlkIGRvbid0IG1hdGNoXG4iOwo+IEBAIC02MTMsNyAr NjEzLDcgQEAgbXkgJHRlc3QxMyA9IHN1YiB7Cj4gICAgICB9Cj4gIAo+ICAgICAgZXZhbCB7Cj4g LQlteSAkdG1wX3ZvbGlkID0gUFZFOjpTdG9yYWdlOjp2ZGlza19hbGxvYygkY2ZnLCAkc3RvcmFn ZW5hbWUsICIxMTMiLCAic3Vidm9sIiwgdW5kZWYgLDEwMjQgKiAxMDI0KTsKPiArCW15ICR0bXBf dm9saWQgPSBQVkU6OlN0b3JhZ2U6OnZkaXNrX2FsbG9jKCRjZmcsICRzdG9yYWdlbmFtZSwgIjEx MyIsICJzdWJ2b2wiLCAxMDI0ICogMTAyNCk7Cj4gIAo+ICAJaWYgKCR0bXBfdm9saWQgbmUgIiRz dG9yYWdlbmFtZTpzdWJ2b2wtMTEzLWRpc2stMCIpIHsKPiAgCSAgICBkaWUgInZvbG5hbWU6JHRt cF92b2xpZCAgZG9uJ3QgbWF0Y2hcbiI7Cj4gQEAgLTYzNyw3ICs2MzcsNyBAQCBteSAkdGVzdDEz ID0gc3ViIHsKPiAgICAgIH0KPiAgCj4gICAgICBldmFsIHsKPiAtCW15ICR0bXBfdm9saWQgPSBQ VkU6OlN0b3JhZ2U6OnZkaXNrX2FsbG9jKCRjZmcsICRzdG9yYWdlbmFtZSwgIjExMyIsICJzdWJ2 b2wiLCB1bmRlZiAsMjA0OCAqIDEwMjQpOwo+ICsJbXkgJHRtcF92b2xpZCA9IFBWRTo6U3RvcmFn ZTo6dmRpc2tfYWxsb2MoJGNmZywgJHN0b3JhZ2VuYW1lLCAiMTEzIiwgInN1YnZvbCIsIDIwNDgg KiAxMDI0KTsKPiAgCj4gIAlpZiAoJHRtcF92b2xpZCBuZSAiJHN0b3JhZ2VuYW1lOnN1YnZvbC0x MTMtZGlzay0xIikgewo+ICAJICAgIGRpZSAidm9sbmFtZTokdG1wX3ZvbGlkICBkb24ndCBtYXRj aFxuIjsKPiAtLSAKPiAyLjM5LjUKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpwdmUtZGV2ZWwgbWFpbGluZyBsaXN0CnB2ZS1kZXZlbEBsaXN0cy5wcm94 bW94LmNvbQpodHRwczovL2xpc3RzLnByb3htb3guY29tL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5m by9wdmUtZGV2ZWwK