From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0E8771FF141 for ; Tue, 16 Jun 2026 11:01:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E0C9E36910; Tue, 16 Jun 2026 11:01:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781600482; x=1782205282; darn=lists.proxmox.com; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qdCbucQi2zZXB5fg8kSjTjK4ncHXFD4fLXbDCo0NW6g=; b=j6TyaCQQj+hOuXKryQSsSegQu88pPuLa951xDOKtzHkaRI4L7LK28akEpGbfeV/I6B wFOibswU/M5yjneuWd9gY4blTjunX3ao6p3zHVNZAhsHKUW/C3ogBj/2gIJGP6bgqZyN HmN3qGZvcOSH2vzzpspikiOEKgdp+mMgxUHJmYduWaMBefiXRlbNVPJEdL8vtFa4rbaw gjMeuRyq7QDjTgMDr9zO7Mna2hcl4iJ1Syvs/sCztKgPLMYms+YAaYcp1gUJ74B2io53 qpQkFBxeatJH2h/i6f3f6+1ypTrvCmebWlGhsucaAfSuvGBQxX7dkQoA8TCFfir0BJG9 +AmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781600482; x=1782205282; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qdCbucQi2zZXB5fg8kSjTjK4ncHXFD4fLXbDCo0NW6g=; b=pMLlaoitoerovF6YqhJntQ6xVXBOtCqQMRh/NIwYwqOPN8ROv13hwnRVzGmfzbHkq8 A/cXH/IDEsb1HbeBZqC0nNCV8LIV+xe56V3lV8lvSzfCRToQH/zVxoXKLct4fFneeVmP OGT9KUOslYop4CKDz/5xSmmfsNiX12LehtFIect81WV317/ZQ52WIxua1dPeZskKo/4x zxvi9mMHNS4ecDExRn0Ycjpz6aISvCSuWqv01jLqdBv96NppVNx6rWmG9hWsSU+mXSOH 3CJK4UGRdSqhZykLe5I5jSGzgDmpSQntwkJGVYpyftlEhk7tR4dFxUx7e/cEDbzZe1nV yPig== X-Gm-Message-State: AOJu0Yzv+WvU76ZTaMu0DJoyIY3FY5SxyjzdJMnYLqsosY7aHY9sAxR9 bOC+rym7vuUBOfAc9T+/AtdiCvqrS+Nv5AWFcDR2IUOvOklHzzplqQrFgb83t5Bb X-Gm-Gg: Acq92OHtO+FIDPm+KE/e/P7UMeP9Foy4SL9xs7hdxBqQ24r5Nxrn5umWLILhDmVEGJx GV8Yhv1MWWiR/KUJGU3cHVoqH5U4iTz/xoOcwVVttnCqtYhIn+CW3dj/aJqtJX/58VEIjOZntJ0 9QzSS3CNPn5nEGa8V3GijizcQ6zMcAKlO+zCF3Mo57Q5RHKr6EcvBxsi9hniQ0e8uvBUpzNzOjv C7mJjMi/18sYwwa0PU1WfSFFYtgmjytJkPUfQrbNITbUP7SYbfX/+0LshZsjrsjwGmEbEumUTmX MdzdjMaqXfqYTLzPguSlqHzL79AWxdEdq142k8DSvdk0wHef+uIq1Pqw8TXCtEB8zhdxj7wdHXt RPBQPw/AWQyPkVx+stgmoz0NaJicXtwFh41SGqjCZLZ2Y7yZC68rkgMWsji8BfgnwIvDqGD7n5D E1CE2jRhWnStwtd8S3aOloodawq9R2fEMfm48E61QylP3uEsqlZpPS X-Received: by 2002:a17:902:f546:b0:2bd:5ae4:26d1 with SMTP id d9443c01a7336-2c699b422d2mr26482895ad.17.1781600481717; Tue, 16 Jun 2026 02:01:21 -0700 (PDT) Message-ID: <346a431f-8851-4084-a6c5-002d66b3d04a@gmail.com> Date: Tue, 16 Jun 2026 17:01:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server] query-machine-capabilities: check vendor string length for strncmp To: pve-devel@lists.proxmox.com References: <20260603055031.106241-1-wukaiyang@loongfans.cn> Content-Language: en-US From: Kaiyang Wu In-Reply-To: <20260603055031.106241-1-wukaiyang@loongfans.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.171 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_ENVFROM_END_DIGIT 1 Envelope-from freemail username ends in digit FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SHNCS22YPLESQO3FY5EDIX2CKYBPANIS X-Message-ID-Hash: SHNCS22YPLESQO3FY5EDIX2CKYBPANIS X-MailFrom: wukaiyang2003@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kaiyang Wu X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Gentle ping, can anyone please take a look? Kaiyang On 2026-06-03 13:50, Kaiyang Wu wrote: > Fix build error on unknown vendors ('fallback'): > > error: ‘strncmp’ of strings of length 7 and 12 and bound of 12 evaluates to nonzero [-Werror=string-compare] > > Signed-off-by: Kaiyang Wu > --- > src/query-machine-capabilities/query-machine-capabilities.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/query-machine-capabilities/query-machine-capabilities.c b/src/query-machine-capabilities/query-machine-capabilities.c > index abb47acd..25d06db7 100644 > --- a/src/query-machine-capabilities/query-machine-capabilities.c > +++ b/src/query-machine-capabilities/query-machine-capabilities.c > @@ -204,7 +204,7 @@ int main() { > eprintf("Error writing to file '" OUTPUT_PATH "': %s\n", strerror(errno)); > } > > - if (strncmp(vendor, "AuthenticAMD", 12) == 0) { > + if (strncmp(vendor, "AuthenticAMD", strnlen(vendor, 12)) == 0) { > cpu_caps_amd_sev_t caps_sev; > query_cpu_capabilities_sev(&caps_sev); > > @@ -222,7 +222,7 @@ int main() { > caps_sev.sev_es_support ? "true" : "false", > caps_sev.sev_snp_support ? "true" : "false" > ); > - } else if (strncmp(vendor, "GenuineIntel", 12) == 0) { > + } else if (strncmp(vendor, "GenuineIntel", strnlen(vendor, 12)) == 0) { > cpu_caps_intel_tdx_t caps_tdx; > if (query_cpu_capabilities_tdx(&caps_tdx) == 0) { > ret = fprintf(file,