From: Erik Fastermann <e.fastermann@proxmox.com>
To: Nicolas Frey <n.frey@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-offline-mirror 1/3] clippy: elide redundant lifetimes
Date: Wed, 22 Jul 2026 14:45:20 +0200 [thread overview]
Message-ID: <33f6054a-cf21-4265-8d65-9e0d2b3899a8@proxmox.com> (raw)
In-Reply-To: <20260226111239.80602-2-n.frey@proxmox.com>
> No functional changes.
>
> for const, 'static lifetime is the default and
> `mountpoint_to_path_exists` had needless lifetimes, so fix it
>
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
LGTM
Reviewed-by: Erik Fastermann <e.fastermann@proxmox.com>
next prev parent reply other threads:[~2026-07-22 12:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 11:12 [PATCH proxmox-offline-mirror 0/3] use proxmox-pgp crate to replace verifier helper module Nicolas Frey
2026-02-26 11:12 ` [PATCH proxmox-offline-mirror 1/3] clippy: elide redundant lifetimes Nicolas Frey
2026-07-22 12:45 ` Erik Fastermann [this message]
2026-02-26 11:12 ` [PATCH proxmox-offline-mirror 2/3] use proxmox-pgp crate to replace verifier helper module Nicolas Frey
2026-07-22 12:45 ` Erik Fastermann
2026-07-22 13:46 ` Nicolas Frey
2026-02-26 11:12 ` [PATCH proxmox-offline-mirror 3/3] verifier: remove module Nicolas Frey
2026-07-22 12:45 ` Erik Fastermann
2026-04-03 13:35 ` [PATCH proxmox-offline-mirror 0/3] use proxmox-pgp crate to replace verifier helper module Nicolas Frey
2026-07-22 14:24 ` superseded: " Nicolas Frey
-- strict thread matches above, loose matches on Subject: below --
2026-07-22 14:22 Nicolas Frey
2026-07-22 14:22 ` [PATCH proxmox-offline-mirror 1/3] clippy: elide redundant lifetimes Nicolas Frey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33f6054a-cf21-4265-8d65-9e0d2b3899a8@proxmox.com \
--to=e.fastermann@proxmox.com \
--cc=n.frey@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.