From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A0B551FF13B for ; Wed, 25 Mar 2026 16:57:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 03CF51FC7D; Wed, 25 Mar 2026 16:58:17 +0100 (CET) Message-ID: <33c11002-5ccb-4113-ab3d-565ea3b93a99@proxmox.com> Date: Wed, 25 Mar 2026 16:57:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-manager 1/8] ui: VMCPUFlagSelector: Fix unknownFlags behaviour To: Arthur Bied-Charreton , pve-devel@lists.proxmox.com References: <20260312084021.124465-1-a.bied-charreton@proxmox.com> <20260312084021.124465-2-a.bied-charreton@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260312084021.124465-2-a.bied-charreton@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774454214981 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XSPYTTFDLHXO7Y7QASNOEF6JDN2YJHRA X-Message-ID-Hash: XSPYTTFDLHXO7Y7QASNOEF6JDN2YJHRA X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 12.03.26 um 9:39 AM schrieb Arthur Bied-Charreton: > ...and typo in name. > > Original patch: > https://lore.proxmox.com/pve-devel/20211028114150.3245864-6-s.reiter@proxmox.com/ > Pre-existing, but the commit message/title should describe what exactly is fixed. Also, might be nicer to have the renaming be a separate commit. > Originally-by: Stefan Reiter > Signed-off-by: Arthur Bied-Charreton > --- > www/manager6/form/VMCPUFlagSelector.js | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js > index 922fcfa6..74b1a2c4 100644 > --- a/www/manager6/form/VMCPUFlagSelector.js > +++ b/www/manager6/form/VMCPUFlagSelector.js > @@ -14,7 +14,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', { > scrollable: 'y', > height: 200, > > - unkownFlags: [], > + unknownFlags: [], > > store: { > type: 'store', > @@ -62,32 +62,32 @@ Ext.define('PVE.form.VMCPUFlagSelector', { > } > }); > > - flags += me.unkownFlags.join(';'); > + flags += (me.unknownFlags.length > 0 ? ';' : '') + me.unknownFlags.join(';'); > > return flags; > }, > > - // Adjusts the store for the current value and determines the unkown flags based on what the > + // Adjusts the store for the current value and determines the unknown flags based on what the > // store does not know. > adjustStoreForValue: function () { > let me = this; > let store = me.getStore(); > let value = me.value; > > - me.unkownFlags = []; > + me.unknownFlags = []; > > store.getData().each((rec) => rec.set('state', '=')); > > let flags = value ? value.split(';') : []; > flags.forEach(function (flag) { > let sign = flag.substr(0, 1); > - flag = flag.substr(1); > + let flagName = flag.substr(1); > > - let rec = store.findRecord('name', flag, 0, false, true, true); > + let rec = store.findRecord('name', flagName, 0, false, true, true); > if (rec !== null) { > rec.set('state', sign); > } else { > - me.unkownFlags.push(flag); > + me.unknownFlags.push(flag); > } > }); >