From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <c.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 952B091D52
for <pbs-devel@lists.proxmox.com>; Thu, 4 Apr 2024 16:51:47 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 77F19518F
for <pbs-devel@lists.proxmox.com>; Thu, 4 Apr 2024 16:51:47 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Thu, 4 Apr 2024 16:51:46 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BA8E7424DF
for <pbs-devel@lists.proxmox.com>; Thu, 4 Apr 2024 16:51:46 +0200 (CEST)
Message-ID: <3357b5da-7d21-4906-9246-07b7af381330@proxmox.com>
Date: Thu, 4 Apr 2024 16:51:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>,
=?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
References: <20240328123707.336951-1-c.ebner@proxmox.com>
<20240328123707.336951-32-c.ebner@proxmox.com>
<1712224223.x1o1szdr2z.astroid@yuna.none>
Content-Language: en-US, de-DE
From: Christian Ebner <c.ebner@proxmox.com>
In-Reply-To: <1712224223.x1o1szdr2z.astroid@yuna.none>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.030 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 31/58] www: cover meta
extension for pxar archives
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 04 Apr 2024 14:51:47 -0000
On 4/4/24 12:01, Fabian Grünbichler wrote:
> On March 28, 2024 1:36 pm, Christian Ebner wrote:
>> Allows to access the pxar meta archives for navigation and download
>> via the Proxmox Backup Server web ui.
>>
>> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>> ---
>> changes since version 2:
>> - use mpxar and ppxar file extensions
>>
>> www/datastore/Content.js | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/www/datastore/Content.js b/www/datastore/Content.js
>> index c2403ff9c..eb25f6ca4 100644
>> --- a/www/datastore/Content.js
>> +++ b/www/datastore/Content.js
>> @@ -1050,7 +1050,7 @@ Ext.define('PBS.DataStoreContent', {
>> tooltip: gettext('Browse'),
>> getClass: (v, m, { data }) => {
>> if (
>> - (data.ty === 'file' && data.filename.endsWith('pxar.didx')) ||
>> + (data.ty === 'file' && (data.filename.endsWith('pxar.didx') || data.filename.endsWith('mpxar.didx'))) ||
>> (data.ty === 'ns' && !data.root)
>> ) {
>> return 'fa fa-folder-open-o';
>> @@ -1058,7 +1058,9 @@ Ext.define('PBS.DataStoreContent', {
>> return 'pmx-hidden';
>> },
>> isActionDisabled: (v, r, c, i, { data }) =>
>> - !(data.ty === 'file' && data.filename.endsWith('pxar.didx') && data['crypt-mode'] < 3) && data.ty !== 'ns',
>> + !(data.ty === 'file' &&
>> + (data.filename.endsWith('pxar.didx') || data.filename.endsWith('mpxar.didx')) &&
>> + data['crypt-mode'] < 3) && data.ty !== 'ns',
>
> is this patch needed? the filename now always ends with pxar.didx (note
> the missing leading '.') ;)
>
> if we want to keep it and only make non-split archives and the meta
> archives browsable, then we need to add the '.'
True, I will add the dot so only pxar and mpxar files can be browsed, as
otherwise it might be confusing (although we allow the ppxar to be used
for the cli commands).