From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1D4451FF187 for ; Mon, 14 Jul 2025 11:47:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2FA55130E3; Mon, 14 Jul 2025 11:48:07 +0200 (CEST) Date: Mon, 14 Jul 2025 11:48:04 +0200 From: Gabriel Goller To: Lukas Wagner Message-ID: <2pww7jgaaqr5tll2xi5nbwbuwbgktfgh4r63relmwd6fn2kwod@n5d3rrvx7lxx> Mail-Followup-To: Lukas Wagner , pve-devel@lists.proxmox.com References: <20250714084553.57147-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250714084553.57147-1-l.wagner@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] www: backup job detail: style fixups using proxmox-biome X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 14.07.2025 10:45, Lukas Wagner wrote: >Signed-off-by: Lukas Wagner >--- > >Notes: > Mea culpa, I did not know that 'make check' does not check for > formatting issues. > > www/manager6/dc/BackupJobDetail.js | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/www/manager6/dc/BackupJobDetail.js b/www/manager6/dc/BackupJobDetail.js >index 464bb558..67ec5273 100644 >--- a/www/manager6/dc/BackupJobDetail.js >+++ b/www/manager6/dc/BackupJobDetail.js >@@ -215,7 +215,7 @@ Ext.define('PVE.dc.BackupInfo', { > let mailto = record?.mailto; > let mailnotification = record?.mailnotification ?? 'always'; > >- if ((value === 'auto' && mailto === undefined) || (value === 'notification-system')) { >+ if ((value === 'auto' && mailto === undefined) || value === 'notification-system') { > return gettext('Use global notification settings'); > } else if (mailnotification === 'always') { > return gettext('Always send email'); >@@ -395,7 +395,9 @@ Ext.define('PVE.dc.BackupInfo', { > let notificationMode = values['notification-mode'] ?? 'auto'; > let mailto = values.mailto; > >- let hideRecipients = (notificationMode === 'auto' && mailto === undefined) || (notificationMode === 'notification-system'); >+ let hideRecipients = >+ (notificationMode === 'auto' && mailto === undefined) || >+ notificationMode === 'notification-system'; > vm.set('hideRecipients', hideRecipients); > > // selection Mode depends on the presence/absence of several keys >-- Looks good to me: Reviewed-by: Gabriel Goller Sorry for not noticing earlier. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel