From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 866C01FF141 for ; Mon, 16 Mar 2026 12:02:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6249E1659E; Mon, 16 Mar 2026 12:03:03 +0100 (CET) Message-ID: <2ff216bd-1823-472b-b45c-49beefa65d5f@proxmox.com> Date: Mon, 16 Mar 2026 12:02:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server v2] api: qmclone: print a message with new VMID To: Maximiliano Sandoval , pve-devel@lists.proxmox.com References: <20260316101405.174423-1-m.sandoval@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260316101405.174423-1-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773658936943 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.063 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VX3CTJEMTGPT5YDNMTS6YACVYQHCC6JI X-Message-ID-Hash: VX3CTJEMTGPT5YDNMTS6YACVYQHCC6JI X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 16.03.26 um 11:13 AM schrieb Maximiliano Sandoval: > When doing a linked clone of a template, the task log, journal, nor the > UPID of the task will log the VMID of the newly created VM. > > We add a log message at the start of the clone. This affects both full > and linked clones. Could you send a patch for containers too to keep it consistent? > diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm > index 1e226f6f..0587ff97 100644 > --- a/src/PVE/API2/Qemu.pm > +++ b/src/PVE/API2/Qemu.pm > @@ -4487,6 +4487,9 @@ __PACKAGE__->register_method({ > my $clonefn = sub { > my ($conffile, $newconf, $oldconf, $vollist, $drives, $fullclone) = > $load_and_check->(); > + > + print("creating a clone of $vmid with ID $newid\n"); I think we should put "of VM $vmid" rather than just the ID like we do in other messages. > + > my $storecfg = PVE::Storage::config(); > > # auto generate a new uuid