From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D2EDD1FF187 for ; Mon, 30 Jun 2025 09:52:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B1C161540A; Mon, 30 Jun 2025 09:52:48 +0200 (CEST) Message-ID: <2ebcc69a-e2ca-400d-8477-452c2d061ac8@proxmox.com> Date: Mon, 30 Jun 2025 09:52:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion References: <20250627155737.162083-1-f.ebner@proxmox.com> <20250627155737.162083-14-f.ebner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 13/31] blockdev: resize: query and use node name for resize operation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 30.06.25 um 08:23 schrieb DERUMIER, Alexandre via pve-devel: > > Hi Fiona, > > from my test, I needed to use the top throttle node to have to new > resize correctly reported to guest > https://lore.proxmox.com/all/mailman.947.1741688963.293.pve-devel@lists.proxmox.com/ Yes, you're right! I originally queried and used the top node (I think your version doesn't work for legacy "-drive", because the node name is auto-generated then), but switched to using the get_node_name_below_throttle() helper after introducing it and didn't check within the VM anymore. So we'll need to switch to something like > my $block_info = get_block_info($vmid); > my $drive_id = $deviceid =~ s/^drive-//r; > my $inserted = $block_info->{$drive_id}->{inserted} > or die "no block node inserted for drive '$drive_id'\n"; > > my $padding = (1024 - $size % 1024) % 1024; > $size = $size + $padding; > > mon_cmd( > $vmid, > "block_resize", > 'node-name' => "$inserted->{'node-name'}", > size => int($size), > timeout => 60, Still, it feels like a QEMU bug. I'd expect the filter node to also report the updated size when its child node is resized. I'll see if that is easily fixed upstream/ask what they think. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel