From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9BBB91FF15C for <inbox@lore.proxmox.com>; Wed, 2 Oct 2024 15:13:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C6731F95C; Wed, 2 Oct 2024 15:13:42 +0200 (CEST) Message-ID: <2e017424-6663-42c6-ac1c-e44d56f9803e@proxmox.com> Date: Wed, 2 Oct 2024 15:13:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pve-devel@lists.proxmox.com References: <20240729115540.191594-1-a.lauterer@proxmox.com> Content-Language: en-US From: Aaron Lauterer <a.lauterer@proxmox.com> In-Reply-To: <20240729115540.191594-1-a.lauterer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH common, widget-toolkit, manager v4 0/7] fix #3893: make bridge vids configurable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> a new v5 has been sent https://lore.proxmox.com/pve-devel/20241002131157.227292-1-a.lauterer@proxmox.com/T/#t On 2024-07-29 13:55, Aaron Lauterer wrote: > since I only incorporated smaller suggested changes, I left the r-b and > t-b in place. > > this version reworks a few parts since > v3: incorporated @shannons recommendations, in detail: > * improve regex with non-capturing group > * reworked check if valid VLAN config in UI field check > * small code style and spelling things > * reworded UI explanation text for bridge vids > > v2: > * renamed format in JSONSchema to a more generic `pve-vlan-id-or-range` > * explicitly use spaces when writing interfaces file. This is one > possible approach to deal with the fact, that the generic `-list` > format will accept quite a few delimiters and we need spaces. > * code style improvements such as naming the regex results. > * add parameter verification to the web ui > > With the changes to the JSONSchema we can then work on using it too for > the guest trunk option. This hasn't been started yet though. > > common: Aaron Lauterer (3): > tools: add check_list_empty function > fix #3893: network: add vlan id and range parameter definitions > inotify: interfaces: make sure bridge_vids use space as separator > > src/PVE/INotify.pm | 2 +- > src/PVE/JSONSchema.pm | 34 ++++++++++++++++++++++++++++++++++ > src/PVE/Tools.pm | 8 ++++++++ > 3 files changed, 43 insertions(+), 1 deletion(-) > > > widget-toolkit: Aaron Lauterer (2): > fix #3892: Network: add bridge vids field for bridge_vids > Network: add explanation for bridge vids field > > src/node/NetworkEdit.js | 73 +++++++++++++++++++++++++++++++++++++++++ > src/node/NetworkView.js | 5 +++ > 2 files changed, 78 insertions(+) > > > manager: Aaron Lauterer (2): > fix #3893: api: network: add bridge_vids parameter > fix #3893: ui: network: enable bridge_vids field > > PVE/API2/Network.pm | 15 ++++++++++++++- > www/manager6/node/Config.js | 1 + > 2 files changed, 15 insertions(+), 1 deletion(-) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel