all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Kaiyang Wu <wukaiyang2003@gmail.com>, pve-devel@lists.proxmox.com
Cc: Kaiyang Wu <wukaiyang@loongfans.cn>
Subject: Re: [PATCH qemu-server v2 1/2] qemuserver: make base path of libGL and libEGL libraries architecture-aware
Date: Thu, 16 Jul 2026 11:32:47 +0200	[thread overview]
Message-ID: <2d1ff200-8d03-4478-942f-d35e72bbc701@proxmox.com> (raw)
In-Reply-To: <20260716073544.284241-2-wukaiyang@loongfans.cn>

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>

On 7/16/26 9:35 AM, Kaiyang Wu wrote:
> 'print_vga_device' assumed x86_64 library path to look for 'libGL.so.1'
> and 'libEGL.so.1', which leads to missing libraries error regardless of
> whether 'libgl1' and 'libegl1' were installed or not, on architectures
> other than x86_64.
> 
> Make base path of the libraries architecture-aware to correctly locate
> the libraries on non-x86_64 architectures.
> 
> Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
> Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
> ---
>   src/PVE/QemuServer.pm | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index 191ae549..c11351bb 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -1540,7 +1540,9 @@ sub print_vga_device {
>       }
>   
>       if ($vga->{type} eq 'virtio-gl') {
> -        my $base = '/usr/lib/x86_64-linux-gnu/lib';
> +        my $host_arch = get_host_arch();
> +        my $base = "/usr/lib/${host_arch}-linux-gnu/lib";
> +
>           die "missing libraries for '$vga->{type}' detected! Please install 'libgl1' and 'libegl1'\n"
>               if !-e "${base}EGL.so.1" || !-e "${base}GL.so.1";
>   





  reply	other threads:[~2026-07-16  9:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16  7:35 [PATCH qemu-server v2 0/2] qemuserver: fix virtio-gpu not being Kaiyang Wu
2026-07-16  7:35 ` [PATCH qemu-server v2 1/2] qemuserver: make base path of libGL and libEGL libraries architecture-aware Kaiyang Wu
2026-07-16  9:32   ` Dominik Csapak [this message]
2026-07-16  7:35 ` [PATCH qemu-server v2 2/2] qemuserver: replace virtio-vga-gl with virtio-gpu-gl on aarch64 Kaiyang Wu
2026-07-16  9:32   ` Dominik Csapak
2026-07-16 10:47     ` superseded: " Kaiyang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d1ff200-8d03-4478-942f-d35e72bbc701@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=wukaiyang2003@gmail.com \
    --cc=wukaiyang@loongfans.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal