From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 968D21FF13B for ; Wed, 20 May 2026 14:08:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1E62C5056; Wed, 20 May 2026 14:08:31 +0200 (CEST) Message-ID: <2cdf89a1-8342-4d63-826e-9c9f32b8372b@proxmox.com> Date: Wed, 20 May 2026 14:08:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: applied: [PATCH manager] ui: cpu flags: add clear trigger to search field To: Thomas Lamprecht , pve-devel@lists.proxmox.com References: <20260520073555.458002-1-d.csapak@proxmox.com> <177927788131.204983.11123106780233231265.b4-ty@b4> Content-Language: en-US From: Dominik Csapak In-Reply-To: <177927788131.204983.11123106780233231265.b4-ty@b4> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779278892090 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 35FFHVKXLR5LCYUNIYVDMRDYQHEYUOBB X-Message-ID-Hash: 35FFHVKXLR5LCYUNIYVDMRDYQHEYUOBB X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/20/26 1:55 PM, Thomas Lamprecht wrote: > On Wed, 20 May 2026 09:35:49 +0200, Dominik Csapak wrote: >> to make it easier to clear it again. > > Applied, thanks! > > btw. I recently factored out the a few times used pattern of such search fields > into a pveRecordSearchField widget (see form/RecordSearchField.js) and now > adopted the clear trigger there and used in in a few other fitting places now. > FWIW, I hesitated to add this to widget-toolkit, as doing that to early adds a > bit extra friction on future fixes and it's still a code reuse win as is. thanks! had a short look and the refactor of that looks very nice! I can already think of a few places where we could reuse that in PVE/PBS. > > [1/1] ui: cpu flags: add clear trigger to search field > commit: 8ad1e5a8919988a42d4791d2bc8eca6c625285c6