From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: applied: [PATCH manager] ui: cpu flags: add clear trigger to search field
Date: Wed, 20 May 2026 14:08:17 +0200 [thread overview]
Message-ID: <2cdf89a1-8342-4d63-826e-9c9f32b8372b@proxmox.com> (raw)
In-Reply-To: <177927788131.204983.11123106780233231265.b4-ty@b4>
On 5/20/26 1:55 PM, Thomas Lamprecht wrote:
> On Wed, 20 May 2026 09:35:49 +0200, Dominik Csapak wrote:
>> to make it easier to clear it again.
>
> Applied, thanks!
>
> btw. I recently factored out the a few times used pattern of such search fields
> into a pveRecordSearchField widget (see form/RecordSearchField.js) and now
> adopted the clear trigger there and used in in a few other fitting places now.
> FWIW, I hesitated to add this to widget-toolkit, as doing that to early adds a
> bit extra friction on future fixes and it's still a code reuse win as is.
thanks!
had a short look and the refactor of that looks very nice!
I can already think of a few places where we could reuse that in
PVE/PBS.
>
> [1/1] ui: cpu flags: add clear trigger to search field
> commit: 8ad1e5a8919988a42d4791d2bc8eca6c625285c6
prev parent reply other threads:[~2026-05-20 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 7:35 [PATCH manager] ui: cpu flags: add clear trigger to search field Dominik Csapak
2026-05-20 11:51 ` applied: " Thomas Lamprecht
2026-05-20 12:08 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cdf89a1-8342-4d63-826e-9c9f32b8372b@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.