From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <h.duerr@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C5D99C153D for <pve-devel@lists.proxmox.com>; Mon, 15 Jan 2024 16:54:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A71FD1DB43 for <pve-devel@lists.proxmox.com>; Mon, 15 Jan 2024 16:53:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Mon, 15 Jan 2024 16:53:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6D1A54434F for <pve-devel@lists.proxmox.com>; Mon, 15 Jan 2024 16:53:36 +0100 (CET) Message-ID: <2ccd9b6e-0fc6-4d6e-9c7a-d6d29d9fa4f3@proxmox.com> Date: Mon, 15 Jan 2024 16:53:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com> References: <20240111105123.370028-1-f.gruenbichler@proxmox.com> Content-Language: en-US From: =?UTF-8?Q?Hannes_D=C3=BCrr?= <h.duerr@proxmox.com> In-Reply-To: <20240111105123.370028-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH cluster/manager/storage/docs 0/9] fix #4886: improve SSH handling X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 15 Jan 2024 15:54:07 -0000 Tested cluster creation with three new nodes on 8.1 and the patches Cluster creation and further ssh communication (eq. migration) worked flawless Tested-by: Hannes Duerr <h.duerr@proxmox.com> On 1/11/24 11:51, Fabian Grünbichler wrote: > this series replaces the old mechanism that used a cluster-wide merged known > hosts file with distributing of each node's host key via pmxcfs, and pinning > the distributed key explicitly for internal SSH connections. > > the main changes in pve-cluster somewhat break the old manager and > storage versions, but only when such a partial upgrade is mixed with a > host key rotation of some sort. > > pve-storage uses a newly introduced helper, so needs a versioned > dependency accordingly. > > the last pve-docs patch has a placeholder for the actual version shipping the > changes which needs to be replaced when applying. > > there's still some potential for follow-ups: > - 'pvecm ssh' wrapper to debug and/or re-use the host key pinning (and other > future changes) > - also add non-RSA host keys > - key (and thus authorized keys) and/or sshd disentangling (this > potentially also affects external access, so might be done on a major > release to give more heads up) > > cluster: > > Fabian Grünbichler (4): > fix #4886: write node SSH hostkey to pmxcfs > fix #4886: SSH: pin node's host key if available > ssh: expose SSH options on their own > pvecm: stop merging SSH known hosts by default > > src/PVE/CLI/pvecm.pm | 10 ++++++++-- > src/PVE/Cluster/Setup.pm | 24 +++++++++++++++++++++--- > src/PVE/SSHInfo.pm | 31 +++++++++++++++++++++++++++---- > 3 files changed, 56 insertions(+), 9 deletions(-) > > docs: > > Fabian Grünbichler (2): > ssh: make pitfalls a regular section instead of block > ssh: document PVE-specific setup > > pvecm.adoc | 26 +++++++++++++++++++++----- > 1 file changed, 21 insertions(+), 5 deletions(-) > > manager: > > Fabian Grünbichler (2): > vnc: use SSH command helper > pvesh: use SSH command helper > > PVE/API2/Nodes.pm | 3 ++- > PVE/CLI/pvesh.pm | 4 ++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > > storage: > > Fabian Grünbichler (1): > upload: use SSH helper to get ssh/scp options > > src/PVE/API2/Storage/Status.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >