From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A36081FF14C for ; Fri, 15 May 2026 11:32:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8158115CB7; Fri, 15 May 2026 11:32:03 +0200 (CEST) Message-ID: <2c9b93e3-0207-4e42-a77b-10b261646daa@proxmox.com> Date: Fri, 15 May 2026 11:31:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH datacenter-manager v2 0/4] add generic, per-remote (and global) cache for remote API responses To: Lukas Wagner , pdm-devel@lists.proxmox.com References: <20260515082855.85698-1-l.wagner@proxmox.com> Content-Language: en-US, de-DE From: Thomas Lamprecht In-Reply-To: <20260515082855.85698-1-l.wagner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778837471686 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LGXG2CCA7JK66UMP3PP4VYIWU3FJHTHV X-Message-ID-Hash: LGXG2CCA7JK66UMP3PP4VYIWU3FJHTHV X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 15/05/2026 10:28, Lukas Wagner wrote: > Changes since v1: > - The only changes happened in the last two patches: > - Improved behavior in case the cache entry could not be read, > mostly to ensure a self-healing behavior > - Slightly restructured code to avoid some clone calls > - When requesting the list of updates for a single remote, update the > global summary cache asynchronously I was writing up a review for v1 and missed this before hitting send. Anyway, some of my v1 comments should still apply.