From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>,
pdm-devel@lists.proxmox.com
Subject: Re: [PATCH datacenter-manager/yew-widget-toolkit 0/2] auto-installer: set proper tooltip for command line show/hide
Date: Thu, 28 May 2026 14:56:24 +0200 [thread overview]
Message-ID: <2b8508d2-8a09-4dc1-8893-179cef52bc87@proxmox.com> (raw)
In-Reply-To: <7957db3c-9527-49fb-b58e-669ca7f4fd43@proxmox.com>
On 5/28/26 2:15 PM, Thomas Lamprecht wrote:
> Am 28.05.26 um 13:19 schrieb Dominik Csapak:
>> i get what the end result should be, but i don't think we should
>> override the 'password' feature with something else.
>
> Why not? A generic "this includes a secret" field seems to be a good
> fit for both? Why duplicate that? (honest question)
>
Judging from the past, we generally don't have any such fields where
it's not a password, so I don't think we'll use this often.
I think we have to be careful what we add to the public API of
the widgets, otherwise we'll add a ton of stuff we don't (often) use.
E.g. the next one maybe needs a different icon for the peek trigger,
or want it left, etc.
Maybe the answer here could also be that the peek trigger be a custom
one? then it's generic enough for my taste to include it.
E.g. something like (would have to flesh out the details of course)
pub peek_trigger: Option<(Trigger, bool)>
(which could get a sensible default implementation)
this way we could also get rid of the 'show_peek_icon' property
and just set it to None on the use site
Don't get me wrong, we can add this property if you prefer that.
>>
>> another way to do this would be to have a custom trigger
>> on the use site and show '******' manually?
>>
>>
>> i just don't believe we will have many uses for changing this tooltip..
> Sure, but what's the cost of having it vs. duplicating the field for
> just having custom tooltips?
prev parent reply other threads:[~2026-05-28 12:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 11:11 [PATCH datacenter-manager/yew-widget-toolkit 0/2] auto-installer: set proper tooltip for command line show/hide Christoph Heiss
2026-05-28 11:11 ` [PATCH yew-widget-toolkit 1/2] form: field: make peek icon tooltip overridable Christoph Heiss
2026-05-28 11:11 ` [PATCH datacenter-manager 2/2] ui: auto-installer: use correct tooltip for command line peek icon Christoph Heiss
2026-05-28 11:19 ` [PATCH datacenter-manager/yew-widget-toolkit 0/2] auto-installer: set proper tooltip for command line show/hide Dominik Csapak
2026-05-28 12:15 ` Thomas Lamprecht
2026-05-28 12:56 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b8508d2-8a09-4dc1-8893-179cef52bc87@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.