From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DED751FF15E for ; Mon, 24 Nov 2025 13:51:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 74B0F22682; Mon, 24 Nov 2025 13:51:32 +0100 (CET) Message-ID: <2b637884-f6bd-434d-be00-fa4e9d9e2dcb@proxmox.com> Date: Mon, 24 Nov 2025 13:51:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , pbs-devel@lists.proxmox.com References: <20251124094018.224661-1-c.ebner@proxmox.com> <176398699637.1851069.5128680534714572156.b4-ty@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <176398699637.1851069.5128680534714572156.b4-ty@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763988654870 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup v2 0/4] fix local marker cleanup for unreferenced, s3 only chunks X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 11/24/25 1:27 PM, Thomas Lamprecht wrote: > On Mon, 24 Nov 2025 10:40:14 +0100, Christian Ebner wrote: >> These patches fix an issue with garbage collection on S3 backends for an >> edge case where the local chunk marker is missing and the chunk not >> being referenced anymore by any index file. In that case garbage >> collection failed when trying to remove the missing marker from the >> local datastore cache. >> >> Fix this by adapting the phase 2 logic such that the atime is now >> optional, skipping over the chunk sweep logic if not set and adding the >> chunk directly for deletion. >> >> [...] > > Applied, thanks! > > While I applied the last patch already as the intentions behind it are > worthwhile to already have, it's IMO not ideal and the function here is already > quite crowded. Maybe creating a local wrapper struc/type around the delete Vec > and age variables and implementing this logic on that struct would be nicer? Yes, bundling all the logic regarding the delete list, including creation and age checks, ecc. into a dedicated struct with its helpers should help de-clutter this a bit. Will have a go at that, thanks! > In any case, really not important for now, in fact, I probably won't even > consider applying such patches this week. > > [1/4] GC: s3: fix local marker cleanup for unreferenced, s3 only chunks > commit: e22be89d6d3f8113fc28a47e08600c759917f43d > [2/4] chunk store: fix and expand the clear_chunk_expected_mark() docstring > commit: d8499811f3cb338f02ccce1beeabd81c57fc129c > [3/4] chunk store: clarify chunk marker helper creates marker if missing > commit: bf279c52b5b8dc82093ad26cdf35ddf8b1b68fe1 > [4/4] datastore: refactor common delete list logic into closure > commit: ed2ae6d3fbbeb19a19a57e9ed7d6ed7e59c22ba0 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel