From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <a.lauterer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 139E1992C8
for <pve-devel@lists.proxmox.com>; Tue, 10 Oct 2023 15:20:00 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id E1F4D33533
for <pve-devel@lists.proxmox.com>; Tue, 10 Oct 2023 15:19:29 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Tue, 10 Oct 2023 15:19:29 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2EC5A4493E
for <pve-devel@lists.proxmox.com>; Tue, 10 Oct 2023 15:19:29 +0200 (CEST)
Message-ID: <2b5d69b7-24e5-409d-8781-30ca2914c800@proxmox.com>
Date: Tue, 10 Oct 2023 15:19:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20230821100651.1167084-1-a.lauterer@proxmox.com>
<d1ac31cd-ef4c-e59c-c5a3-38f849c7a271@proxmox.com>
From: Aaron Lauterer <a.lauterer@proxmox.com>
In-Reply-To: <d1ac31cd-ef4c-e59c-c5a3-38f849c7a271@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.077 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint
when to enable shared
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 10 Oct 2023 13:20:00 -0000
On 10/10/23 15:06, Fiona Ebner wrote:
> Am 21.08.23 um 12:06 schrieb Aaron Lauterer:
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>> www/manager6/storage/DirEdit.js | 4 ++++
>> www/manager6/storage/LVMEdit.js | 4 ++++
>> 2 files changed, 8 insertions(+)
>>
>> diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
>> index 7e9ec44d..8469a7c3 100644
>> --- a/www/manager6/storage/DirEdit.js
>> +++ b/www/manager6/storage/DirEdit.js
>> @@ -30,6 +30,10 @@ Ext.define('PVE.storage.DirInputPanel', {
>> name: 'shared',
>> uncheckedValue: 0,
>> fieldLabel: gettext('Shared'),
>> + autoEl: {
>> + tag: 'div',
>> + 'data-qtip': gettext('Enable if the underlying file system is already shared between nodes.'),
>> + }
>
> eslint complains about missing trailing comma
hmm, when did that happen... now it does it too for me. Will send another version with it fixed.
>
>> },
>> ];
>>
>> diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
>> index 75c7bdb8..0d9efd21 100644
>> --- a/www/manager6/storage/LVMEdit.js
>> +++ b/www/manager6/storage/LVMEdit.js
>> @@ -227,6 +227,10 @@ Ext.define('PVE.storage.LVMInputPanel', {
>> name: 'shared',
>> uncheckedValue: 0,
>> fieldLabel: gettext('Shared'),
>> + autoEl: {
>> + tag: 'div',
>> + 'data-qtip': gettext('Enable if the LVM is located on a shared LUN.'),
>> + }
>
> eslint complains about missing trailing comma
>
>> },
>> ],
>> });
>
> With those fixed:
> Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>