From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 450E51FF15C for ; Fri, 25 Jul 2025 13:54:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1031C17310; Fri, 25 Jul 2025 13:56:07 +0200 (CEST) Message-ID: <2b112958-02c8-45d9-ace1-cc2ea76aaff1@proxmox.com> Date: Fri, 25 Jul 2025 13:55:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta From: Dominik Csapak To: pbs-devel@lists.proxmox.com References: <20250725113657.3815270-1-d.csapak@proxmox.com> Content-Language: en-US In-Reply-To: <20250725113657.3815270-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753444529498 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [hpe.com] Subject: Re: [pbs-devel] [PATCH proxmox-backup] tape: increase timeout for moving medium in changer X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" meh sorry, i wrote '30 minutes' in the commit message when it should be '45' i can send a v2 if necessary (or it could be fixed up on commit ?) On 7/25/25 13:37, Dominik Csapak wrote: > from the current 5 minutes to 30 minutes. According to documentation > from vendors (e.g. HP see [0]) moving a medium between slots or to/from > a drive can take up a much longer time than 5 minutes. (up to 38 minutes > in a HP library) so increase the timeout we use here to something that > exceeds these recommendations. > > 0: https://support.hpe.com/hpesc/public/docDisplay?docId=sd00001714en_us&page=GUID-D7147C7F-2016-0901-065E-00000000072C.html > > Signed-off-by: Dominik Csapak > --- > pbs-tape/src/sg_pt_changer.rs | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/pbs-tape/src/sg_pt_changer.rs b/pbs-tape/src/sg_pt_changer.rs > index 7122fcdb4..dd297a822 100644 > --- a/pbs-tape/src/sg_pt_changer.rs > +++ b/pbs-tape/src/sg_pt_changer.rs > @@ -18,6 +18,7 @@ use crate::{ > }; > > const SCSI_CHANGER_DEFAULT_TIMEOUT: usize = 60 * 5; // 5 minutes > +const SCSI_CHANGER_MOVE_MEDIUM_TIMEOUT: usize = 60 * 45; // 45 minutes > const SCSI_VOLUME_TAG_LEN: usize = 36; > > /// Initialize element status (Inventory) > @@ -181,7 +182,7 @@ pub fn load_slot(file: &mut File, from_slot: u64, drivenum: u64) -> Result<(), E > ); > > let mut sg_raw = SgRaw::new(file, 64)?; > - sg_raw.set_timeout(SCSI_CHANGER_DEFAULT_TIMEOUT); > + sg_raw.set_timeout(SCSI_CHANGER_MOVE_MEDIUM_TIMEOUT); > > sg_raw > .do_command(&cmd) > @@ -205,7 +206,7 @@ pub fn unload(file: &mut File, to_slot: u64, drivenum: u64) -> Result<(), Error> > ); > > let mut sg_raw = SgRaw::new(file, 64)?; > - sg_raw.set_timeout(SCSI_CHANGER_DEFAULT_TIMEOUT); > + sg_raw.set_timeout(SCSI_CHANGER_MOVE_MEDIUM_TIMEOUT); > > sg_raw > .do_command(&cmd) > @@ -233,7 +234,7 @@ pub fn transfer_medium( > ); > > let mut sg_raw = SgRaw::new(file, 64)?; > - sg_raw.set_timeout(SCSI_CHANGER_DEFAULT_TIMEOUT); > + sg_raw.set_timeout(SCSI_CHANGER_MOVE_MEDIUM_TIMEOUT); > > sg_raw.do_command(&cmd).map_err(|err| { > format_err!( _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel