From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 9E12D9581
 for <pve-devel@lists.proxmox.com>; Tue, 26 Apr 2022 10:49:46 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 907B818E98
 for <pve-devel@lists.proxmox.com>; Tue, 26 Apr 2022 10:49:46 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 1737B18E8D
 for <pve-devel@lists.proxmox.com>; Tue, 26 Apr 2022 10:49:46 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E41F042B46
 for <pve-devel@lists.proxmox.com>; Tue, 26 Apr 2022 10:49:45 +0200 (CEST)
Message-ID: <2a3ad089-7508-5b1d-91c8-c823599f5092@proxmox.com>
Date: Tue, 26 Apr 2022 10:49:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101
 Thunderbird/100.0
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Stoiko Ivanov <s.ivanov@proxmox.com>
References: <20220304151059.3787765-1-s.ivanov@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20220304151059.3787765-1-s.ivanov@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.030 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [acme.sh]
Subject: [pve-devel] applied: [PATCH proxmox-acme 0/2] add missing
 readdomainconf and helper script
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 26 Apr 2022 08:49:46 -0000

On 04.03.22 16:10, Stoiko Ivanov wrote:
> The first patch addresses a issue reported in our community forum.
> 
> The second patch is meant as a suggestion - and can happily be dropped.
> Since it's the second time I ran into trying to find a sensible diff of what
> is missing in proxmox-acme, but present in upstream acme.sh and adapted
> the grep - I thought it might make sense to have it in the repo.
> 
> Stoiko Ivanov (2):
>   plugin-caller: add _readdomainconf stub
>   add shellscript to find needed functions not provided by proxmox-acme
> 
>  check-missing-functions | 13 +++++++++++++
>  src/proxmox-acme        |  5 +++++
>  2 files changed, 18 insertions(+)
>  create mode 100755 check-missing-functions
> 


applied, thanks!

Reduced false-positives in a followup, moved to the src/test directory and added to the
test make target to compare the output with a known-ok false-positive list tracked in git.