Re: [PATCH datacenter-manager v5 00/10] refactor and partially fix #7371

[Dominik Csapak <d.csapak@proxmox.com>]

FYI: this version has a bug that the tags are shown double in the 
resource tree. (this could be a fixup or i can send
a new version depending on the remaining review)

On 10/2/26 4:15 PM, Dominik Csapak wrote:
> the first 6 patches are pure refactors and should not change anything
> user visible, could be applied independently.
> 
> patch 7,8,10 partially fix #7371 by showing the HA maintenance status
> of PVE nodes in various places.
> 
> patch 9 is just a fix that came up  (thanks @lukas)
> 
> NOTE: requires my recent tree view patches[0] applied first
> 
> changes from v4:
> * rebase on master and on [0]
> 
> chagnes from v3:
> * rebase on master
> * add serde skip_serialize_if for option none on the ha maintenance field
> * added new patch for sorting by memory usage correctly
> 
> changes from v2:
> * add missing doc comments
> * refine wording a bit and make it more consistent (HA -> ha for example)
> * change from string 'hastate' to proper rust enum 'ha-state' in
>    PveNodeResource struct
> 
> changes from v1:
> * fixed some display problems: NaN% when maxmem was set to 0.0,
>    0.0% cpu when the node was offline, fixed by not showing values for
>    offline nodes
> * add a new patch for showing tha badge too in the node card's title
> * various typo fixes
> * added #[serde(default)] to the new hastate field to allow
>    deserialization from older versions
> * some smaller fixes  (left over comments, naming, etc.)
> 
> 0: https://lore.proxmox.com/pdm-devel/20261002135324.3147672-1-d.csapak@proxmox.com/T/#t
> 
> Dominik Csapak (10):
>    lib: api types: add new ResourceView type and move accessors there
>    lib: api types: resource: add 'node' helper to ResourceView
>    lib: api types: add guest specific getter to ResourceView
>    ui: pve: factor out the pve-manager version extraction
>    ui: renderer: use ResourceView for rendering
>    ui: pve: tree: reuse `PveResource` for `PveTreeNode`
>    ui: pve: show ha maintenance mode for nodes
>    ui: pve: node selector: show maintenance badge with node name
>    ui: pve: node selector: sort memory columns by usage not by memory
>      size
>    ui: pve: node: show ha maintenance badge
> 
>   lib/pdm-api-types/src/resource.rs  | 336 ++++++++++++++++++++++-------
>   server/src/api/resources.rs        |   1 +
>   ui/pwt-assets                      |   2 +-
>   ui/src/dashboard/top_entities.rs   |   5 +-
>   ui/src/guests.rs                   |   6 +-
>   ui/src/lib.rs                      |  23 +-
>   ui/src/pve/mod.rs                  |  73 ++++---
>   ui/src/pve/node/mod.rs             |  15 +-
>   ui/src/pve/tree.rs                 | 298 ++++++++++++-------------
>   ui/src/renderer.rs                 |  80 ++++---
>   ui/src/widget/pve_node_selector.rs |  95 +++++---
>   ui/src/widget/resource_tree.rs     |  11 +-
>   12 files changed, 576 insertions(+), 369 deletions(-)
>