From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <aderumier@odiso.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 6477861A09
 for <pve-devel@lists.proxmox.com>; Tue, 15 Sep 2020 08:28:27 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 4D70616B16
 for <pve-devel@lists.proxmox.com>; Tue, 15 Sep 2020 08:27:57 +0200 (CEST)
Received: from mailpro.odiso.net (mailpro.odiso.net [89.248.211.110])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 0284F16B0A
 for <pve-devel@lists.proxmox.com>; Tue, 15 Sep 2020 08:27:56 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
 by mailpro.odiso.net (Postfix) with ESMTP id 9C5E11A5B90C;
 Tue, 15 Sep 2020 08:27:49 +0200 (CEST)
Received: from mailpro.odiso.net ([127.0.0.1])
 by localhost (mailpro.odiso.net [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id NRMuyBebz2St; Tue, 15 Sep 2020 08:27:49 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
 by mailpro.odiso.net (Postfix) with ESMTP id 81CAC1A5B90D;
 Tue, 15 Sep 2020 08:27:49 +0200 (CEST)
X-Virus-Scanned: amavisd-new at mailpro.odiso.com
Received: from mailpro.odiso.net ([127.0.0.1])
 by localhost (mailpro.odiso.net [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id DFvnaPLkSayG; Tue, 15 Sep 2020 08:27:49 +0200 (CEST)
Received: from mailpro.odiso.net (mailpro.odiso.net [10.1.31.111])
 by mailpro.odiso.net (Postfix) with ESMTP id 6A5EE1A5B90C;
 Tue, 15 Sep 2020 08:27:49 +0200 (CEST)
Date: Tue, 15 Sep 2020 08:27:49 +0200 (CEST)
From: Alexandre DERUMIER <aderumier@odiso.com>
To: dietmar <dietmar@proxmox.com>
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>, 
 Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Message-ID: <295606419.745430.1600151269212.JavaMail.zimbra@odiso.com>
In-Reply-To: <487514223.9.1600148741895@webmail.proxmox.com>
References: <216436814.339545.1599142316781.JavaMail.zimbra@odiso.com>
 <9e2974b8-3c39-0fda-6f73-6677e3d796f4@proxmox.com>
 <1928266603.714059.1600059280338.JavaMail.zimbra@odiso.com>
 <803983196.1499.1600067690947@webmail.proxmox.com>
 <2093781647.723563.1600072074707.JavaMail.zimbra@odiso.com>
 <88fe5075-870d-9197-7c84-71ae8a25e9dd@proxmox.com>
 <1775665592.735772.1600098305930.JavaMail.zimbra@odiso.com>
 <487514223.9.1600148741895@webmail.proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Mailer: Zimbra 8.8.12_GA_3866 (ZimbraWebClient - GC83 (Linux)/8.8.12_GA_3844)
Thread-Topic: corosync bug: cluster break after 1 node clean shutdown
Thread-Index: s0TVq+rEROXRyiy+kllSKdnGwY9MHA==
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.036 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_NONE     -0.0001 Sender listed at https://www.dnswl.org/,
 no trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [shutdown.target, time-sync.target, network.target]
Subject: Re: [pve-devel] corosync bug: cluster break after 1 node clean
 shutdown
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 15 Sep 2020 06:28:27 -0000

>>This is by intention - we do not want to stop pmxcfs only because coorosy=
nc service stops.=20

Yes, but at shutdown, it could be great to stop pmxcfs before corosync ?
I ask the question, because the 2 times I have problem, it was when shuttin=
g down a server.
So maybe some strange behaviour occur with both corosync && pmxcfs are stop=
ped at same time ?


looking at the pve-cluster unit file,
why do we have "Before=3Dcorosync.service" and not "After=3Dcorosync.servic=
e" ?

I have tried to change this, but even with that, both are still shutting do=
wn in parallel.

the only way I have found to have clean shutdown, is "Requires=3Dcorosync.s=
erver" + "After=3Dcorosync.service".
But that mean than if you restart corosync, it's restart pmxcfs too first.

I have looked at systemd doc, After=3D should be enough (as at shutdown it'=
s doing the reverse order),
but I don't known why corosync don't wait than pve-cluster ???


(Also, I think than pmxcfs is also stopping after syslog, because I never s=
ee the pmxcfs "teardown filesystem" logs at shutdown)



----- Mail original -----
De: "dietmar" <dietmar@proxmox.com>
=C3=80: "aderumier" <aderumier@odiso.com>, "Thomas Lamprecht" <t.lamprecht@=
proxmox.com>
Cc: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Envoy=C3=A9: Mardi 15 Septembre 2020 07:45:41
Objet: Re: [pve-devel] corosync bug: cluster break after 1 node clean shutd=
own

> Now, that logging work, I'm also seeeing pmxcfs errors when corosync is s=
topping.=20
> (But no pmxcfs shutdown log)=20
>=20
> Do you think it's possible to have a clean shutdown of pmxcfs first, befo=
re stopping corosync ?=20

This is by intention - we do not want to stop pmxcfs only because coorosync=
 service stops.=20

Unit]=20
Description=3DThe Proxmox VE cluster filesystem=20
ConditionFileIsExecutable=3D/usr/bin/pmxcfs=20
Wants=3Dcorosync.service=20
Wants=3Drrdcached.service=20
Before=3Dcorosync.service=20
Before=3Dceph.service=20
Before=3Dcron.service=20
After=3Dnetwork.target=20
After=3Dsys-fs-fuse-connections.mount=20
After=3Dtime-sync.target=20
After=3Drrdcached.service=20
DefaultDependencies=3Dno=20
Before=3Dshutdown.target=20
Conflicts=3Dshutdown.target=20