From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3D5861FF185 for ; Mon, 21 Jul 2025 14:39:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 18EECE981; Mon, 21 Jul 2025 14:40:56 +0200 (CEST) Message-ID: <2924a8b2-3d6c-42d7-bdde-b7a6b8bfbbf1@proxmox.com> Date: Mon, 21 Jul 2025 14:40:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Aaron Lauterer References: <20250715143218.1548306-1-a.lauterer@proxmox.com> <20250715143218.1548306-25-a.lauterer@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20250715143218.1548306-25-a.lauterer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753101614469 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v3 11/14] ui: nodesummary: guestsummary: add tooltip info buttons X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" mhmm not too sure about this. IMHO this info belongs in the documentation instead of in a tooltip, but I get why we want to maybe have an explanation for these easily reachable. First, I'd use the panel tool icons here instead of font awesomes, like e.g. the undo zoom and close button (from the windows) Second, maybe having that button link to the correct section in the docs is better in the long run. On 7/15/25 16:32, Aaron Lauterer wrote: > This way, we can provide a bit more context to what the graph is > showing. Hopefully making it easier for our users to draw useful > conclusions from the provided information. > > Signed-off-by: Aaron Lauterer > --- > > Notes: > while not available for all graphs for now, this should help users > understand the more complex ones. > > The phrasing might be improved of course. > > www/manager6/node/Summary.js | 40 ++++++++++++++++++++++++++++++ > www/manager6/panel/GuestSummary.js | 30 ++++++++++++++++++++++ > 2 files changed, 70 insertions(+) > > diff --git a/www/manager6/node/Summary.js b/www/manager6/node/Summary.js > index b00fcf2e..7bd3324c 100644 > --- a/www/manager6/node/Summary.js > +++ b/www/manager6/node/Summary.js > @@ -162,6 +162,16 @@ Ext.define('PVE.node.Summary', { > { > xtype: 'proxmoxRRDChart', > title: gettext('CPU usage'), > + tools: [ > + { > + glyph: 'xf05a@FontAwesome', // fa-info-circle > + tooltip: gettext("IO Delay is a measure of how much time processes had to wait for IO to be finished."), > + disabled: false, > + style: { > + paddingRight: '5px', > + }, > + }, > + ], > fields: ['cpu', 'iowait'], > fieldTitles: [gettext('CPU usage'), gettext('IO delay')], > unit: 'percent', > @@ -199,6 +209,16 @@ Ext.define('PVE.node.Summary', { > { > xtype: 'proxmoxRRDChart', > title: gettext('CPU pressure'), > + tools: [ > + { > + glyph: 'xf05a@FontAwesome', // fa-info-circle > + tooltip: gettext("Shows if some processes on the host had to wait for CPU resources."), > + disabled: false, > + style: { > + paddingRight: '5px', > + }, > + }, > + ], > fieldTitles: ['Some'], > fields: ['pressurecpusome'], > colors: ['#FFD13E', '#A61120'], > @@ -208,6 +228,16 @@ Ext.define('PVE.node.Summary', { > { > xtype: 'proxmoxRRDChart', > title: gettext('IO pressure'), > + tools: [ > + { > + glyph: 'xf05a@FontAwesome', // fa-info-circle > + tooltip: gettext("Shows if some or all (Full) processes on the host had to wait for IO (disk & network) resources."), > + disabled: false, > + style: { > + paddingRight: '5px', > + }, > + }, > + ], > fieldTitles: ['Some', 'Full'], > fields: ['pressureiosome', 'pressureiofull'], > colors: ['#FFD13E', '#A61120'], > @@ -217,6 +247,16 @@ Ext.define('PVE.node.Summary', { > { > xtype: 'proxmoxRRDChart', > title: gettext('Memory pressure'), > + tools: [ > + { > + glyph: 'xf05a@FontAwesome', // fa-info-circle > + tooltip: gettext("Shows if some or all (Full) processes on the host had to wait for memory resources."), > + disabled: false, > + style: { > + paddingRight: '5px', > + }, > + }, > + ], > fieldTitles: ['Some', 'Full'], > fields: ['pressurememorysome', 'pressurememoryfull'], > colors: ['#FFD13E', '#A61120'], > diff --git a/www/manager6/panel/GuestSummary.js b/www/manager6/panel/GuestSummary.js > index e26b0ada..cf54f38e 100644 > --- a/www/manager6/panel/GuestSummary.js > +++ b/www/manager6/panel/GuestSummary.js > @@ -127,6 +127,16 @@ Ext.define('PVE.guest.Summary', { > { > xtype: 'proxmoxRRDChart', > title: gettext('CPU pressure'), > + tools: [ > + { > + glyph: 'xf05a@FontAwesome', // fa-info-circle > + tooltip: gettext("Shows if some or all (Full) processes belonging to the guest had to wait for CPU resources."), > + disabled: false, > + style: { > + paddingRight: '5px', > + }, > + }, > + ], > pveSelNode: me.pveSelNode, > fieldTitles: ['Some', 'Full'], > fields: ['pressurecpusome', 'pressurecpufull'], > @@ -137,6 +147,16 @@ Ext.define('PVE.guest.Summary', { > { > xtype: 'proxmoxRRDChart', > title: gettext('IO pressure'), > + tools: [ > + { > + glyph: 'xf05a@FontAwesome', // fa-info-circle > + tooltip: gettext("Shows if some or all (Full) processes belonging to the guest had to wait for IO (disk & network) resources."), > + disabled: false, > + style: { > + paddingRight: '5px', > + }, > + }, > + ], > pveSelNode: me.pveSelNode, > fieldTitles: ['Some', 'Full'], > fields: ['pressureiosome', 'pressureiofull'], > @@ -147,6 +167,16 @@ Ext.define('PVE.guest.Summary', { > { > xtype: 'proxmoxRRDChart', > title: gettext('Memory pressure'), > + tools: [ > + { > + glyph: 'xf05a@FontAwesome', // fa-info-circle > + tooltip: gettext("Shows if some or all (Full) processes belonging to the guest had to wait for memory resources."), > + disabled: false, > + style: { > + paddingRight: '5px', > + }, > + }, > + ], > pveSelNode: me.pveSelNode, > fieldTitles: ['Some', 'Full'], > fields: ['pressurememorysome', 'pressurememoryfull'], _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel