From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DCF1F96D26 for <pbs-devel@lists.proxmox.com>; Fri, 1 Mar 2024 12:43:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C319730DD9 for <pbs-devel@lists.proxmox.com>; Fri, 1 Mar 2024 12:43:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pbs-devel@lists.proxmox.com>; Fri, 1 Mar 2024 12:43:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D94654837F for <pbs-devel@lists.proxmox.com>; Fri, 1 Mar 2024 12:43:13 +0100 (CET) Message-ID: <27bdeeee-a91c-47ab-ae20-c52f512e632f@proxmox.com> Date: Fri, 1 Mar 2024 12:43:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20240301090341.1342682-1-d.csapak@proxmox.com> <20240301090341.1342682-2-d.csapak@proxmox.com> Content-Language: en-GB From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20240301090341.1342682-2-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] applied: Re: [PATCH widget-toolkit 1/1] dns: optionally send delete for optional values X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 01 Mar 2024 11:43:14 -0000 On 01/03/2024 10:03, Dominik Csapak wrote: > pbs only deletes the optional values here when they are sent with the > 'delete' parameter, in contrast to pve/pmg that don't have a delete > parameter currently and always use the parameters as source of truth. > > So to handle that, optionally set deleteEmpty if set from outside > > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> > --- > src/node/DNSEdit.js | 6 ++++++ > src/node/DNSView.js | 4 ++++ > 2 files changed, 10 insertions(+) > > applied, with a follow up for the comment to avoid coupling this to a specific downstream dependency, that just will get outdated and has not much use on its own anyway here, thanks!