From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E34521FF183 for ; Wed, 30 Jul 2025 16:25:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8E66710DA4; Wed, 30 Jul 2025 16:26:27 +0200 (CEST) Message-ID: <26b67ef7-9eba-43b2-bc3c-99970805a6df@proxmox.com> Date: Wed, 30 Jul 2025 16:25:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Lukas Wagner , Proxmox Backup Server development discussion References: <20250728064645.158414-1-c.ebner@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753885543940 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} 00/10] s3: implement list buckets and use bucket selector for datastore creation X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 7/30/25 3:46 PM, Lukas Wagner wrote: > On Mon Jul 28, 2025 at 8:46 AM CEST, Christian Ebner wrote: >> This patches aim to increase usability for the user by allowing to list >> accessible buckets during datastore creation. >> >> For this, the proxmox s3 client is extended by the list buckets method, fetching >> accessible buckets from the s3 api. This requires the client instantiation to be >> possible without the bucket name, making it therefore optional. Further, the >> regex for the config endpoint url must be restricted to have the bucket name >> template pattern always at the start of the template. With these changes, it is >> then possible to fetch the buckets given the required permissions to do so. >> >> On the proxmox backup server side, the api endpoints to fetch the bucket list >> are implemented as well as the corresponding cli command. Finally, the bucket >> name field in the datastore edit window is replaced by an s3 bucket selector, >> which loads the accessible bucket names via the api. >> > > Already reported to Chris off-list, but there seems to be something > wrong in the response parser when multiple buckets are returned: > > $ proxmox-backup-manager s3 endpoint list-buckets minio > Error: failed to list buckets > > Caused by: > 0: failed to parse response body > 1: custom: duplicate field `Bucket` > > If I remove all but one buckets from the MinIO server, it works. Thanks for catching this! Will be fixed in a version 2 of the patches. I will also work on some regression tests for the whole of the s3 client response parsing. This I will however send as followup patches. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel