From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 91B181FF15C for ; Wed, 19 Feb 2025 11:06:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 64C251C8B0; Wed, 19 Feb 2025 11:06:22 +0100 (CET) Message-ID: <25b5507d-d790-4c8e-85ed-cb4939a43e09@proxmox.com> Date: Wed, 19 Feb 2025 11:06:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner To: Proxmox VE development discussion , Markus Frank References: <20250122100901.74830-1-m.frank@proxmox.com> <20250122100901.74830-3-m.frank@proxmox.com> Content-Language: en-US In-Reply-To: <20250122100901.74830-3-m.frank@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH guest-common v13 2/12] add dir mapping section config X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 22.01.25 um 11:08 schrieb Markus Frank: > +my $map_fmt = { > + node => get_standard_option('pve-node'), > + path => { > + description => "Absolute directory path that should be shared with the guest.", > + type => 'string', > + format => 'pve-storage-path', I now noticed that paths with commas do not work for the mapping. They cannot be passed along, since the API endpoint requires the full mapping as a property string and we have no way of escaping commas AFAIK. To make it work, we could require paths to be (base64?) encoded when passed via API. We might also want to think about writing them encoded to the config file since it's also saved as the property string there. If we do not want to support such paths, I think we should restrict the allowed characters, e.g. our storage plugin already has a $SAFE_CHAR_WITH_WHITESPACE_CLASS_RE that could be used to register a restricted format (if we don't already have one). Doesn't support anything non-ASCII either though. And it does support '=' which causes issues in the UI (seems to work in the backend though). @other devs: opinions? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel