From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 4995B1FF2C5
	for <inbox@lore.proxmox.com>; Mon,  8 Jul 2024 11:37:11 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 9BA6AF3A;
	Mon,  8 Jul 2024 11:37:28 +0200 (CEST)
Message-ID: <23f73092-b6b2-49ad-9edd-2e118934eca8@proxmox.com>
Date: Mon, 8 Jul 2024 11:37:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Max Carrara <m.carrara@proxmox.com>
References: <20240705134651.296607-1-l.wagner@proxmox.com>
 <D2K08TIGI4VP.1F4SFR561B7PC@proxmox.com>
Content-Language: de-AT, en-US
From: Lukas Wagner <l.wagner@proxmox.com>
In-Reply-To: <D2K08TIGI4VP.1F4SFR561B7PC@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.005 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH many v8 00/13] notifications: notification
 metadata matching improvements
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On  2024-07-08 10:12, Max Carrara wrote:
> On Fri Jul 5, 2024 at 3:46 PM CEST, Lukas Wagner wrote:
>> This patch series attempts to improve the user experience when creating
>> notification matchers.
> 
> The below can pretty much just be considered "proofreading" as I haven't
> built and tested your changes, but since you already got a lot of
> feedback on the last couple versions, I think that's fine. ;) Just
> wanted to comment anyway.
> 
> The patches are rather easy to follow, and even though I'm no expert
> when it comes to Ext JS, the UI changes look fine to me too. The new UI
> logic feels (and is) much cleaner than before. There's nothing I can
> otherwise comment on; everything's pretty straight-forward.
> 
> The *only* things I have noticed are rather minor - there are two tiny
> typos in the commit messages of patch 01 and 02, but these can probably
> be fixed when applying the series:
>   01: Last sentence of message - "It it can be considered internal." 
>   02: First sentence of message - "This allows us to access us the [...]"
> 
> That's it otherwise from me - LGTM.
> 
> Reviewed-by: Max Carrara <m.carrara@proxmox.com>
> 

Thanks a lot for your review, Max!

I'll send a v9 with the typos fixed and your R-b's added.

-- 
- Lukas


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel