From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0A3D696722 for <pmg-devel@lists.proxmox.com>; Wed, 25 Jan 2023 11:05:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DEF5AD096 for <pmg-devel@lists.proxmox.com>; Wed, 25 Jan 2023 11:04:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pmg-devel@lists.proxmox.com>; Wed, 25 Jan 2023 11:04:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7E119460E3 for <pmg-devel@lists.proxmox.com>; Wed, 25 Jan 2023 11:04:36 +0100 (CET) Message-ID: <23c4bf9b-2dbd-caf7-9a06-ae2745640aca@proxmox.com> Date: Wed, 25 Jan 2023 11:04:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:110.0) Gecko/20100101 Thunderbird/110.0 Content-Language: en-GB, de-AT To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com References: <20230123155521.28307-1-s.ivanov@proxmox.com> <20230123155521.28307-2-s.ivanov@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20230123155521.28307-2-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [utils.pm, postfix.org, proxmox.com] Subject: [pmg-devel] applied: [PATCH pmg-api 1/2] utils: skip checking headers for non-ascii characters X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion <pmg-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/> List-Post: <mailto:pmg-devel@lists.proxmox.com> List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 25 Jan 2023 10:05:09 -0000 Am 23/01/2023 um 16:55 schrieb Stoiko Ivanov: > the fix for smtputf8 enablement in > 191e4709e99a5975fa66cf21847887566e108501 was a bit too eager and broke > the mailflow of a few users, who have smtputf8 disabled in their > postfix config (because their downstream servers do not support this): > > The issue here is that the mails they process have had > (non-rfc-compliant) non-ascii header contents, which used to work > before the patch. The postfix smtputf8 howto explains quite well that > postfix never cared too much about headers (or local-parts of > addresses) before smtputf8 [1] > ``` > Postfix already permitted UTF-8 in message header values and in > address localparts. This does not change. > ``` > > While the patch only ignores the headers and still could cause issues > with non-ascii local-parts, those should occur far less frequently in > the wild (none of the reporters in our forum had this). > > tested with a mail with an Euro sign in a 'X-From:' header. > > [0] https://forum.proxmox.com/threads/.120886/ > [1] https://www.postfix.org/SMTPUTF8_README.html#enabling > > Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com> > --- > src/PMG/Utils.pm | 4 ---- > 1 file changed, 4 deletions(-) > > applied, with slightly touched up commit message, mostly to denote that this is a stop gap, thanks!