From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 711821FF135 for ; Sun, 19 Apr 2026 23:45:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 47F9C17BD2; Sun, 19 Apr 2026 23:45:21 +0200 (CEST) Message-ID: <23bcbb76-58f9-4929-b3fd-d4e6e4c3af42@proxmox.com> Date: Sun, 19 Apr 2026 23:44:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: applied: [PATCH v4 0/5] client: repository: add individual component parameters To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260410154327.4133440-1-t.lamprecht@proxmox.com> <07eee76f-6065-48d5-babb-dcd40a2c3881@proxmox.com> Content-Language: en-US, de-DE From: Thomas Lamprecht In-Reply-To: <07eee76f-6065-48d5-babb-dcd40a2c3881@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776635003945 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YF7B6KT345B3VSBD6RULKINJY6HIGHQ5 X-Message-ID-Hash: YF7B6KT345B3VSBD6RULKINJY6HIGHQ5 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 17/04/2026 14:25, Christian Ebner wrote: > On 4/10/26 5:43 PM, Thomas Lamprecht wrote: >> Follow-up to [v3], reworked based on Wolfgang's and Christian's review >> feedback - thx! >> >> The compact repository URL format ([[auth-id@]server[:port]:]datastore) >> can be cumbersome to work with when changing a single aspect of the >> connection or when using API tokens. This series adds --server, --port, >> --datastore, --auth-id, and --ns as separate CLI parameters alongside >> the existing compound --repository URL. >> >> Changes since [v3]: >> - Deduplicated mutual-exclusion check into check_mutual_exclusion() >> - Used AllOfSchema for mount.rs raw ApiMethod definitions >> - Commands where --ns is irrelevant (login, logout, version, status, GC, >>    benchmark, task) now use BackupRepositoryArgs only >> - Moved optional_ns_param() to pbs-client tools as shared helper >> - Fixed change_backup_owner not stripping atom fields before forwarding >> - Small nits (anyhow::bail! -> bail!, private ENV_VAR_PBS_NAMESPACE) >> >> Changes since [v2]: >> - Deduplicated param resolution cascade into shared helper >> - Split into BackupRepositoryArgs and BackupTargetArgs (repo + ns) >> >> Changes since [v1]: >> - Split single commit into five >> - CLI atoms now merge with PBS_* env vars per-field (CLI wins) >> - Fixed mutual-exclusion error swallowing and duplicate ns property >> - PBS_NAMESPACE works uniformly across all three client binaries >> >> [v3]: https://lore.proxmox.com/pbs-devel/20260401225305.4069441-1-t.lamprecht@proxmox.com/ >> [v2]: https://lore.proxmox.com/pbs-devel/20260330182352.2346420-1-t.lamprecht@proxmox.com/ >> [v1]: https://lore.proxmox.com/pbs-devel/20260323211400.2661765-1-t.lamprecht@proxmox.com/ > > > Reviewed-by: Christian Ebner > Tested-by: Christian Ebner Many tanks. I squashed in a fix for the style issues you found and pushed this out with your review trailers (but no link trailers, should have re-applied them with "b4" argh…).