From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0882B1FF170 for ; Thu, 7 Aug 2025 14:15:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 153241D7DE; Thu, 7 Aug 2025 14:17:22 +0200 (CEST) Message-ID: <2192cf28-8da4-4054-93a9-5cd859f83d9e@proxmox.com> Date: Thu, 7 Aug 2025 14:17:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pbs-devel@lists.proxmox.com References: <20250807120308.257071-2-s.sterz@proxmox.com> Content-Language: en-US From: Mira Limbeck In-Reply-To: <20250807120308.257071-2-s.sterz@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754569015307 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.285 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 0/2] add support for HttpOnly cookies for OpenID authentication flow X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 8/7/25 14:02, Shannon Sterz wrote: > these two patches do the following: > > 1. add a `http-only` parameter to the OpenID login endpoint, so clients > can opt into receive the authentication ticket via a HttpOnly cookie > 2. opt the ui dialog into using this new HttpOnly parameter > > this should fix a bug where users were instantly logged out again after > a successful OpenID authentication. > > changes since v1, thanks @ Mira Limbeck: > > - fixed an issue where the open id login endpoint would return a > `ticket_info` field instead of a `ticket-info` field. > > Shannon Sterz (2): > api: openid: allow users of openid to opt into the HttpOnly cookies > ui: opt open id authentication flows into the new http only flow > > src/api2/access/openid.rs | 346 ++++++++++++++++++++++---------------- > www/LoginView.js | 1 + > 2 files changed, 206 insertions(+), 141 deletions(-) > > -- > 2.47.2 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > Gave this a quick test. Looks good! Both cookies are now set. Consider this: Tested-by: Mira Limbeck _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel