From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <l.wagner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2EA5DBABEC for <pbs-devel@lists.proxmox.com>; Thu, 21 Mar 2024 11:24:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 17BFD1C39A for <pbs-devel@lists.proxmox.com>; Thu, 21 Mar 2024 11:24:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pbs-devel@lists.proxmox.com>; Thu, 21 Mar 2024 11:24:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D664C40C0B for <pbs-devel@lists.proxmox.com>; Thu, 21 Mar 2024 11:24:40 +0100 (CET) Message-ID: <20ceb8c8-fb04-4e5b-a22b-f3141f17af4d@proxmox.com> Date: Thu, 21 Mar 2024 11:24:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Lukas Wagner <l.wagner@proxmox.com> To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Stefan Lendl <s.lendl@proxmox.com> References: <20240208135953.2078165-1-s.lendl@proxmox.com> Content-Language: de-AT, en-US In-Reply-To: <20240208135953.2078165-1-s.lendl@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 0/8] *** SUBJECT HERE *** X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 21 Mar 2024 10:24:42 -0000 On 2024-02-08 14:59, Stefan Lendl wrote: > *** BLURB HERE *** > > Stefan Lendl (8): > api: garbage collect job status > gc: global prune and gc job view > gc: move datastore/PruneAndGC to config/PruneAndGC > gc: hide datastore column in local gc view > ui: order Prune&GC before SyncJobs > cli: list gc jobs with proxmox-backup-manager > gc: show removed and pending chunks of last run in ui > gc: configure width and flex on GC Jobs columns > > pbs-api-types/src/datastore.rs | 40 +++++ > src/api2/admin/datastore.rs | 129 +++++++++++++++- > src/api2/admin/gc.rs | 57 +++++++ > src/api2/admin/mod.rs | 2 + > src/bin/proxmox-backup-manager.rs | 33 ++++ > www/Makefile | 4 +- > www/Utils.js | 6 +- > www/config/GCView.js | 243 ++++++++++++++++++++++++++++++ > www/config/PruneAndGC.js | 52 +++++++ > www/datastore/DataStoreList.js | 11 +- > www/datastore/Panel.js | 3 +- > www/datastore/PruneAndGC.js | 133 ---------------- > www/window/GCJobEdit.js | 28 ++++ > 13 files changed, 593 insertions(+), 148 deletions(-) > create mode 100644 src/api2/admin/gc.rs > create mode 100644 www/config/GCView.js > create mode 100644 www/config/PruneAndGC.js > delete mode 100644 www/datastore/PruneAndGC.js > create mode 100644 www/window/GCJobEdit.js > Apart from the requested change from chunks to bytes, these changes look good to me :) Please make sure to include the cover letter in v4 ;) With the suggested UI/API changes, consider this: Tested-by: Lukas Wagner <l.wagner@proxmox.com> Reviewed-by: Lukas Wagner <l.wagner@proxmox.com> -- - Lukas