From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <aderumier@odiso.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 831016BA03 for <pve-devel@lists.proxmox.com>; Sun, 13 Dec 2020 15:21:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A7637EA8E for <pve-devel@lists.proxmox.com>; Sun, 13 Dec 2020 15:21:06 +0100 (CET) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 97E7CEA7E for <pve-devel@lists.proxmox.com>; Sun, 13 Dec 2020 15:21:04 +0100 (CET) Received: by mail-wr1-x430.google.com with SMTP id c5so10177079wrp.6 for <pve-devel@lists.proxmox.com>; Sun, 13 Dec 2020 06:21:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=odiso-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=kJso4eApYZIKoWQUbW+X1cCpfbt3WZr3KEpScJm39os=; b=VfTz2fXfhox/k41F5vuzHvFO0sU5gCHD5m9Ix7YTSchbVCX6wR72uT4GPxpCA1No3J tWWFt+DVWL2Q21HxBiBwonRgpo4s/V9Q5RLdgCSgZGLhjVPDC5tSezO8FSVKqeZLzy5t 1hrPh3hVnmWz5nt6jcjDrM4Ak44GDlLgCYjNJgsqRxHAeHqCnRokJIt8ibEoXFQjr6xU p5IdKTWqrjv5UOVa2j2cOYMf2D+GOdkr84tTTTNduHVbzoYnA/WyHOqVZl76IO5jsUX3 blr1Fn7JVaZV/WkxXOGXFaCO3Ez0CmLOtywC3F9FRqlH8eK3JaPgaCh9iFvE6T6bg/6m FiEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=kJso4eApYZIKoWQUbW+X1cCpfbt3WZr3KEpScJm39os=; b=PBbyQbXqgaQUkn3mMuXG+h7dnYCPQvO4K784ApUgDeTZtPl1qHEAtfBjYxmFmFloX/ DoVXjSx3/AWqu6sNL7n2bN5bJCNa4p4wl4FgqwQKECpFOWaKXa4lXTUsIbIBMkYRmdbt yXAgIU6bXfHYptS8pNPI0QYgI63FM3iOC0Iw6ZO08kwMB9eWQeXWItuBXzkmQDrd2nlx qAR+mCp6oXsk0QvCF8nKdlhm0FchdLS8slXH8tsVoyGVl2n0tRxVAhQgK8Nb3fWsL+sI gYXrC0QVfzxqNciRJyYQx7UNEdRv2NvLxUa3G/k3UZTRqIJPgP5E5Diq3K48jP2cJwhQ 56CQ== X-Gm-Message-State: AOAM531/cDUibdX8mEP4OeA7ZR3CTd6YtQnF0qwc6FoPchRqts8crHvd nJeg3/mYZwvTIXulMmZn9PamDuSTp9NpxkXW X-Google-Smtp-Source: ABdhPJxuOoJU7zxR7sHL/5NfgXTJWsv6Hg0xAMxPVQF1hfW645UPnf7uOOv5iTfJPca9rq5l2H3inQ== X-Received: by 2002:a5d:4e8c:: with SMTP id e12mr23647584wru.321.1607869258231; Sun, 13 Dec 2020 06:20:58 -0800 (PST) Received: from [192.168.178.20] ([79.132.253.97]) by smtp.gmail.com with ESMTPSA id c129sm25993087wma.31.2020.12.13.06.20.57 for <pve-devel@lists.proxmox.com> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Dec 2020 06:20:57 -0800 (PST) To: pve-devel@lists.proxmox.com References: <CAPEXuiwNr3OjBh9ArMiBToVAD6EXf5Rp+Ph7OswvAkmFWPmUwg@mail.gmail.com> <dba3eab5-6b50-a235-8f62-c07c0827f45c@odiso.com> <CAPEXuizOTE-D20ijT_shrxZkiYt89UF-+OFK-RzWvefhb_J0Gw@mail.gmail.com> <21a61f20-2889-189c-084e-221fbb93d720@odiso.com> <CAPEXuizSuDVjjZFk_fKzJ9cmS-Q80yUkv1MeE1QSU6F2j5tMWg@mail.gmail.com> From: alexandre derumier <aderumier@odiso.com> Message-ID: <2098e15a-356d-872a-d9ac-720ea3d4406d@odiso.com> Date: Sun, 13 Dec 2020 15:20:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <CAPEXuizSuDVjjZFk_fKzJ9cmS-Q80yUkv1MeE1QSU6F2j5tMWg@mail.gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.167 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [pve-manager] sdn: Adding phpIPAM as IPAM provider X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Sun, 13 Dec 2020 14:21:37 -0000 On 11/12/2020 19:34, Bruce Wainer wrote: > Looking at the code, it doesn't appear that the MAC of the interface is > being passed into phpIPAM, if this is known then I'd prefer that it be > passed via add_ip and add_next_freeip. yes, indeed, currently I don't register the mac, but I could add it, no problem. (could be used by a dhcp server for example) I'll send a patch next week, thanks for the report !