From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 481481FF0AF for ; Fri, 20 Nov 2026 19:31:28 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0084C215FD; Fri, 20 Nov 2026 19:31:27 +0100 (CET) From: Gabriel Goller To: pve-devel@lists.proxmox.com Subject: [PATCH network v2] sdn: zones: warn about host interfaces in a missing zone VRF Date: Fri, 20 Nov 2026 19:31:15 +0100 Message-ID: <20261120183116.478378-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795199482377 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.217 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PODYRJ7LGVSCQRPVNZXTZBAUFXOOV6BO X-Message-ID-Hash: PODYRJ7LGVSCQRPVNZXTZBAUFXOOV6BO X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Thomas Lamprecht X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Disabling dedicated-vrf, removing the node from a zone or deleting the zone removes its VRF, but host interfaces may still be in it. ifreload then cannot enslave them or add their gateway, which is easy to miss in the apply log. Warn when generating the SDN network config of the node, as only the node sees its own interfaces file. A host stanza for the VRF only counts if it sets vrf-table, since a stanza that just adds an address to the SDN VRF would otherwise hide the warning once the zone is gone. Files sourced from /etc/network/interfaces are not checked. The PVE parser does not follow source directives, and the rest of SDN, such as the SNAT uplink lookup, does not look at them either. A host VRF named like a zone VRF in a sourced file therefore gives a false warning, and an interface defined in a sourced file is not checked at all. This seems acceptable for a best-effort warning. Suggested-by: Thomas Lamprecht Signed-off-by: Gabriel Goller --- Changes in v2: - Only skip the warning for a host stanza of the VRF if it sets vrf-table. Before, any host stanza with the VRF's name hid the warning, including one that only adds an address to the SDN VRF. - Say in the warning that the VRF is defined neither in /etc/network/interfaces nor in the SDN config of this node. - Shorten the code comment and explain the sourced-files limitation in the commit message instead. - Link to v1: https://lore.proxmox.com/pve-devel/20261120141157.192734-1-g.goller@proxmox.com/ src/PVE/Network/SDN/Zones.pm | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/src/PVE/Network/SDN/Zones.pm b/src/PVE/Network/SDN/Zones.pm index 1c90ea769a41..2a44723feec2 100644 --- a/src/PVE/Network/SDN/Zones.pm +++ b/src/PVE/Network/SDN/Zones.pm @@ -11,6 +11,7 @@ use PVE::Tools qw(extract_param dir_glob_regex run_command); use PVE::Cluster qw(cfs_read_file cfs_write_file cfs_lock_file); use PVE::IPRoute2; use PVE::Network; +use PVE::RESTEnvironment qw(log_warn); use PVE::Network::SDN::Controllers; use PVE::Network::SDN::Dns; @@ -228,6 +229,23 @@ sub generate_etc_network_config { } } + # Warn about host interfaces in a zone VRF that is no longer generated, e.g. after the zone + # was deleted. Sourced files are not checked. + my $host_ifaces = $interfaces_config->{ifaces}; + for my $iface (sort keys $host_ifaces->%*) { + my $vrf = $host_ifaces->{$iface}->{vrf}; + next if !$vrf || $vrf !~ m/^vrf_/; + next if $config->{$vrf}; + + my $host_vrf = $host_ifaces->{$vrf} // {}; + # make sure this is actually a VRF and isn't just named like one + my @options = (($host_vrf->{options} // [])->@*, ($host_vrf->{options6} // [])->@*); + next if grep { m/^vrf-table\s/ } @options; + + log_warn("host interface '$iface' is in VRF '$vrf', which is not defined in" + . " /etc/network/interfaces or the SDN configuration of this node"); + } + my $raw_network_config = "\#version:$version\n"; foreach my $iface (sort keys %$config) { $raw_network_config .= "\n"; -- 2.47.3