From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 70C9C1FF0AF for ; Fri, 20 Nov 2026 17:00:41 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 718CB21737; Fri, 20 Nov 2026 17:00:38 +0100 (CET) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Subject: [PATCH pve-network 04/10] api: fabric status: document omitted WireGuard interface values Date: Fri, 20 Nov 2026 17:00:19 +0100 Message-ID: <20261120160026.512565-5-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261120160026.512565-1-s.hanreich@proxmox.com> References: <20261120160026.512565-1-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795190433189 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.211 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZEULTUECZTYBMO3OP3I3IHEADDXC4CLL X-Message-ID-Hash: ZEULTUECZTYBMO3OP3I3IHEADDXC4CLL X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The interface status of WireGuard fabrics omits the public key and listen port if WireGuard does not report them, instead of falling back to the configured values. It also omits the type if the interface is missing or is not a WireGuard interface, instead of reporting the kind of an arbitrary interface on the node, so mark it as optional. Signed-off-by: Stefan Hanreich --- src/PVE/API2/Network/SDN/Nodes/Fabric.pm | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/PVE/API2/Network/SDN/Nodes/Fabric.pm b/src/PVE/API2/Network/SDN/Nodes/Fabric.pm index d5c97ba..f588b41 100644 --- a/src/PVE/API2/Network/SDN/Nodes/Fabric.pm +++ b/src/PVE/API2/Network/SDN/Nodes/Fabric.pm @@ -232,21 +232,26 @@ __PACKAGE__->register_method({ }, type => { description => - "The type of this interface in the fabric (e.g. Point-to-Point, Broadcast, ..).", + "The type of this interface in the fabric (e.g. Point-to-Point, Broadcast, ..)." + . " Omitted for WireGuard if the interface is missing or is not a WireGuard" + . " interface.", type => 'string', + optional => 1, }, state => { description => "The current state of the interface.", type => 'string', }, 'public-key' => { - description => "The public key of the interface (WireGuard only).", + description => "The public key of the interface, omitted if WireGuard does" + . " not report one (WireGuard only).", format_description => 'Base64-encoded Curve 25519 public key.', type => 'string', optional => 1, }, 'listen-port' => { - description => "The listen port of the interface (WireGuard only).", + description => "The listen port of the interface, omitted if WireGuard does" + . " not report the interface (WireGuard only).", type => 'number', optional => 1, }, -- 2.47.3