From: Lukas Sichert <l.sichert@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Lukas Sichert <l.sichert@proxmox.com>
Subject: [PATCH manager 3/4] ui: lvm: keep other on-volume-remove options when editing
Date: Fri, 20 Nov 2026 14:32:42 +0100 [thread overview]
Message-ID: <20261120133245.51042-4-l.sichert@proxmox.com> (raw)
In-Reply-To: <20261120133245.51042-1-l.sichert@proxmox.com>
The edit dialog rebuilt the on-volume-remove property string from the
discard checkbox alone, so saving the dialog dropped every other
option in it. This would silently remove options that can only be set
through the API or CLI, such as discard_throughput.
Remember the options without a field of their own when loading the
storage and submit them again with the checkbox state.
Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
---
www/manager6/storage/LVMEdit.js | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
index 9308ef4e..75861214 100644
--- a/www/manager6/storage/LVMEdit.js
+++ b/www/manager6/storage/LVMEdit.js
@@ -151,7 +151,8 @@ Ext.define('PVE.storage.LVMInputPanel', {
onGetValues: function (values) {
let me = this;
- let onRemove = {};
+ // options without a field of their own, like discard_throughput, must survive an edit
+ let onRemove = { ...me.otherOnRemoveOptions };
if (values['on-remove-discard']) {
onRemove.discard = 1;
}
@@ -178,6 +179,8 @@ Ext.define('PVE.storage.LVMInputPanel', {
if (values['on-volume-remove']) {
let onRemove = PVE.Parser.parsePropertyString(values['on-volume-remove']);
values['on-remove-discard'] = onRemove.discard;
+ delete onRemove.discard;
+ this.otherOnRemoveOptions = onRemove;
}
delete values['on-volume-remove'];
--
2.47.3
next prev parent reply other threads:[~2026-11-20 13:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 13:32 [PATCH docs/manager/storage 0/4] fix #8196: lvm: add a throughput limit for discards Lukas Sichert
2026-11-20 13:32 ` [PATCH storage 1/4] lvm: rename the saferemove throughput parser to parse_throughput Lukas Sichert
2026-11-20 13:32 ` [PATCH storage 2/4] fix #8196: lvm: add discard throughput limit Lukas Sichert
2026-11-20 13:32 ` Lukas Sichert [this message]
2026-11-20 13:32 ` [PATCH docs 4/4] storage: lvm: document the " Lukas Sichert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120133245.51042-4-l.sichert@proxmox.com \
--to=l.sichert@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.