all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH container 3/3] config: check type: add reminder to improve checks for major release
Date: Fri, 20 Nov 2026 12:19:18 +0100	[thread overview]
Message-ID: <20261120111949.71436-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20261120111949.71436-1-f.ebner@proxmox.com>

The check_type() implementation for container configuration handling
is less complete compared to the one from JSONSchema and does not
cover checking 'pattern', 'minimum', 'enum', etc.

There could be some fallout from tightening the checks, so it might
be better to wait until the next major release.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/LXC/Config.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 2441b2f..d0b0c85 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -1441,6 +1441,7 @@ sub update_pct_config {
     return $errors;
 }
 
+# FIXME: MAJOR VERSION: use JSONSchema::check_type (or check_prop?) to check 'pattern', etc.
 sub check_type {
     my ($class, $key, $value) = @_;
 
-- 
2.47.3





  parent reply	other threads:[~2026-11-20 11:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 11:19 [PATCH-SERIES qemu-server/container 0/3] fix #8354: config: gracefully handle empty 'running-nets-host-mtu' Fiona Ebner
2026-11-20 11:19 ` [PATCH qemu-server 1/3] " Fiona Ebner
2026-11-20 11:19 ` [PATCH qemu-server 2/3] config: check type: add reminder to improve checks for major release Fiona Ebner
2026-11-20 11:19 ` Fiona Ebner [this message]
2026-11-20 12:00 ` applied: [PATCH-SERIES qemu-server/container 0/3] fix #8354: config: gracefully handle empty 'running-nets-host-mtu' Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120111949.71436-4-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal