From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 14A001FF0AF for ; Fri, 20 Nov 2026 12:20:01 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E2982216BC; Fri, 20 Nov 2026 12:19:58 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 2/3] config: check type: add reminder to improve checks for major release Date: Fri, 20 Nov 2026 12:19:17 +0100 Message-ID: <20261120111949.71436-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261120111949.71436-1-f.ebner@proxmox.com> References: <20261120111949.71436-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795173593426 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.249 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: I2AJXW75CM5DTVMIO7H5RPYGGN5FRUV2 X-Message-ID-Hash: I2AJXW75CM5DTVMIO7H5RPYGGN5FRUV2 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The check_type() implementation for VM configuration handling is less complete compared to the one from JSONSchema and does not cover checking 'pattern', 'minimum', 'enum', etc. There could be some fallout from tightening the checks, so it might be better to wait until the next major release. Signed-off-by: Fiona Ebner --- src/PVE/QemuServer.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 763cfd39..268716f8 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -1776,6 +1776,7 @@ sub cloudinit_pending_properties { return $p; } +# FIXME: MAJOR VERSION: use JSONSchema::check_type (or check_prop?) to check 'pattern', etc. sub check_type { my ($key, $value, $schema) = @_; -- 2.47.3