From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 2A6521FF0DA for ; Thu, 19 Nov 2026 20:52:50 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C33C321DD1; Thu, 19 Nov 2026 20:48:39 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH v8 manager 43/43] ui: node: san: add a column for the target or subsystem of a LUN Date: Thu, 19 Nov 2026 20:46:48 +0100 Message-ID: <20261119194655.3163258-44-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261119194655.3163258-1-t.lamprecht@proxmox.com> References: <20261119194655.3163258-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795117623925 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.151 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TFH55XX7TUUAX7YE7OL7JFXAO6G44MU6 X-Message-ID-Hash: TFH55XX7TUUAX7YE7OL7JFXAO6G44MU6 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The inventory reports the iSCSI target a LUN is attached through and the subsystem of an NVMe namespace, but the list did not show them. The name tells where a LUN comes from, which helps most with an array or a storage plugin that exports one target or subsystem per volume and names it after that volume. One column shows either, so that it also sorts by both. The column is hidden by default; the search covers it either way. Likewise, the LUN column shows the namespace ID for a namespace, which the inventory reports too, and stayed empty for it so far. Signed-off-by: Thomas Lamprecht --- www/manager6/SANUtils.js | 15 +++++++++++++++ www/manager6/node/SANLuns.js | 10 +++++++++- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/www/manager6/SANUtils.js b/www/manager6/SANUtils.js index 520a397cd..f4905e680 100644 --- a/www/manager6/SANUtils.js +++ b/www/manager6/SANUtils.js @@ -26,6 +26,21 @@ Ext.define('pve-san-lun', { 'multipath-storage', 'iscsi-target', 'iscsi-lun', + 'nvme-subsystem', + 'nvme-nsid', + // one column shows the target of a LUN and the subsystem of a namespace + { + name: 'target', + depends: ['iscsi-target', 'nvme-subsystem'], + calculate: (data) => data['iscsi-target'] || data['nvme-subsystem'] || '', + sortType: 'asUCString', + }, + // and one the number of a LUN and the ID of a namespace + { + name: 'lun', + depends: ['iscsi-lun', 'nvme-nsid'], + calculate: (data) => data['iscsi-lun'] ?? data['nvme-nsid'], + }, // the texts of the Name and Used By columns, which also sort by them { name: 'display-name', diff --git a/www/manager6/node/SANLuns.js b/www/manager6/node/SANLuns.js index 45b45f725..e2c954d57 100644 --- a/www/manager6/node/SANLuns.js +++ b/www/manager6/node/SANLuns.js @@ -96,7 +96,14 @@ Ext.define('PVE.node.SANLunList', { width: 100, renderer: PVE.SANUtils.renderSanTransport, }, - { text: 'LUN', dataIndex: 'iscsi-lun', width: 60, hidden: true }, + { + text: gettext('Target') + '/' + gettext('Subsystem'), + dataIndex: 'target', + flex: 2, + hidden: true, + renderer: Ext.htmlEncode, + }, + { text: 'LUN/NSID', dataIndex: 'lun', width: 100, hidden: true }, { text: gettext('Vendor'), dataIndex: 'vendor', @@ -195,6 +202,7 @@ Ext.define('PVE.node.SANLunList', { 'detail', 'multipath-storage', 'devpath', + 'target', 'path-search', 'vendor', 'model',