From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 96CF11FF0DA for ; Thu, 19 Nov 2026 20:51:34 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1542521C83; Thu, 19 Nov 2026 20:48:34 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH v8 manager 34/43] ui: storage: iscsi: add the multipath option Date: Thu, 19 Nov 2026 20:46:39 +0100 Message-ID: <20261119194655.3163258-35-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261119194655.3163258-1-t.lamprecht@proxmox.com> References: <20261119194655.3163258-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795117623380 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.152 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JD5OSU5AWGMP4ZYJ4BVSSPKHZ477G6AF X-Message-ID-Hash: JD5OSU5AWGMP4ZYJ4BVSSPKHZ477G6AF X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Offer the multipath option in the dialog of an iSCSI storage. With it the nodes of the storage combine the paths of each LUN into one multipath device, without multipath being set up on every node by hand. Enabling the option on an existing storage does not move logical volumes and guests that are already active on individual paths. Show that limit in the dialog when the option gets enabled there, and link to the documentation on checking the device dependencies. Signed-off-by: Thomas Lamprecht --- www/manager6/storage/IScsiEdit.js | 43 +++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/www/manager6/storage/IScsiEdit.js b/www/manager6/storage/IScsiEdit.js index 670077e05..7929a13b3 100644 --- a/www/manager6/storage/IScsiEdit.js +++ b/www/manager6/storage/IScsiEdit.js @@ -77,6 +77,15 @@ Ext.define('PVE.storage.IScsiInputPanel', { lunContent: 'images', + // Loading sets the value before its original value, so use the dirty state. + updateMultipathActivation: function () { + let me = this; + let field = me.down('field[name=managed-multipath]'); + me.lookup('multipathActivation').setHidden( + me.isCreate || !field.getValue() || !field.isDirty(), + ); + }, + onGetValues: function (values) { let me = this; @@ -156,5 +165,39 @@ Ext.define('PVE.storage.IScsiInputPanel', { checked: true, fieldLabel: gettext('Use LUNs directly'), }, + { + xtype: 'proxmoxcheckbox', + name: 'managed-multipath', + fieldLabel: gettext('Multipath'), + cbind: { + deleteEmpty: '{!isCreate}', + }, + autoEl: { + tag: 'div', + 'data-qtip': gettext( + 'Combine the paths of each LUN into one device on every node using the storage.', + ), + }, + listeners: { + change: (field) => field.up('inputpanel').updateMultipathActivation(), + dirtychange: (field) => field.up('inputpanel').updateMultipathActivation(), + }, + }, + { + xtype: 'displayfield', + reference: 'multipathActivation', + userCls: 'pmx-hint', + htmlEncode: false, + hidden: true, + cbind: { + value: () => + Ext.String.format( + gettext( + 'Active logical volumes and guests using individual paths do not switch to the multipath map. Check their device dependencies before relying on path redundancy (documentation).', + ), + Ext.htmlEncode(Proxmox.Utils.get_help_link('storage_multipath')), + ), + }, + }, ], });