all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-common v3 01/28] interfaces: preserve VRF membership across address family changes
Date: Thu, 19 Nov 2026 20:40:47 +0100	[thread overview]
Message-ID: <20261119194116.575520-2-g.goller@proxmox.com> (raw)
In-Reply-To: <20261119194116.575520-1-g.goller@proxmox.com>

Store VRF membership as an interface option, not an address family
option. Otherwise, switching from IPv4 to IPv6-only can drop the VRF
assignment when the IPv4 stanza is removed.

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 src/PVE/Network/Interfaces.pm | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/PVE/Network/Interfaces.pm b/src/PVE/Network/Interfaces.pm
index 8aed1ab3c473..1737ec5c014b 100644
--- a/src/PVE/Network/Interfaces.pm
+++ b/src/PVE/Network/Interfaces.pm
@@ -134,7 +134,7 @@ my $check_mtu = sub($ifaces, $parent, $child) {
 #       gateway6 => IP,
 #       comments6 => [ "..." ],
 #
-#       <known options>, # like bridge_ports, ovs_*
+#       <known options>, # interface-wide (shared by inet/inet6): bridge_ports, ovs_*, vrf
 #
 #       # extra/unknown options stored by-family:
 #       options => { <inet options>... }
@@ -226,6 +226,7 @@ sub __read_etc_network_interfaces($fh, $ip_links = undef, $active_ifaces = undef
 
                     my $simple_options = {
                         'mtu' => 1,
+                        'vrf' => 1,
                         'ovs_type' => 1,
                         'ovs_options' => 1,
                         'ovs_bridge' => 1,
@@ -885,6 +886,7 @@ sub __write_etc_network_interfaces($config, $ifupdown2 = undef) {
                 my $n = $ifaces->{$p};
                 $n->{autostart} = 1;
                 die "OVS bond '$iface' - unable to find slave '$p'\n" if !$n;
+                die "OVS bond '$iface' - slave '$p' cannot have a VRF master\n" if $n->{vrf};
                 die
                     "OVS bond '$iface' - wrong interface type on slave '$p' ('$n->{type}' != 'eth')\n"
                     if $n->{type} ne 'eth';
@@ -893,6 +895,13 @@ sub __write_etc_network_interfaces($config, $ifupdown2 = undef) {
         }
     }
 
+    # OVS interfaces are not supported in VRFs
+    foreach my $iface (keys %$ifaces) {
+        my $d = $ifaces->{$iface};
+        die "iface '$iface' - VRF is not supported on OVS interfaces\n"
+            if $d->{vrf} && $d->{type} =~ m/^OVS/;
+    }
+
     # check bond
     foreach my $iface (keys %$ifaces) {
         my $d = $ifaces->{$iface};
@@ -904,6 +913,7 @@ sub __write_etc_network_interfaces($config, $ifupdown2 = undef) {
             $n->{autostart} = 1;
 
             die "bond '$iface' - unable to find slave '$p'\n" if !$n;
+            die "bond '$iface' - slave '$p' cannot have a VRF master\n" if $n->{vrf};
             die
                 "bond '$iface' - wrong interface type on slave '$p' ('$n->{type}' != 'eth or bond')\n"
                 if ($n->{type} ne 'eth' && $n->{type} ne 'bond');
@@ -1027,6 +1037,7 @@ sub __write_etc_network_interfaces($config, $ifupdown2 = undef) {
                 }
                 my $n = $ifaces_copy->{$p};
                 die "bridge '$iface' - unable to find bridge port '$p'\n" if !$n;
+                die "bridge '$iface' - port '$p' cannot have a VRF master\n" if $n->{vrf};
                 die "iface $p - ip address can't be set on interface if bridged in $iface\n"
                     if ($n->{method} && $n->{method} eq 'static' && $n->{address} ne '0.0.0.0')
                     || ($n->{method6} && $n->{method6} eq 'static' && $n->{address6} ne '::');
-- 
2.47.3





  reply	other threads:[~2026-11-19 19:41 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 19:40 [PATCH common/manager/network/proxmox{-ve-rs,-perl-rs,-widget-toolkit} v3 00/28] SDN VRF support Gabriel Goller
2026-11-19 19:40 ` Gabriel Goller [this message]
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 02/28] frr: add VRF-aware OSPF rendering Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 03/28] sdn: add zone references to OSPF and BGP fabrics Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 04/28] sdn: generate fabric routing configuration in zone VRFs Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 05/28] sdn: fix VRF route-map scoping and zone ID validation Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 06/28] tests: fabrics: add tests for fabrics in VRFs Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-ve-rs v3 07/28] sdn: allow static routes in simple zone VRFs Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-perl-rs v3 08/28] pve-rs: fabrics: assign network interfaces to configured VRFs Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-perl-rs v3 09/28] pve-rs: fabrics: make per-fabric status queries VRF-aware Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-perl-rs v3 10/28] pve-rs: fabrics: include VRF routes in aggregate status Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-perl-rs v3 11/28] pve-rs: fabrics: expose host interface membership Gabriel Goller
2026-11-19 19:40 ` [PATCH proxmox-perl-rs v3 12/28] sdn: expose static routes for simple zone uplinks Gabriel Goller
2026-11-19 19:40 ` [PATCH pve-network v3 13/28] sdn: evpn: add unreachable IPv6 default route to zone VRFs Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 14/28] sdn: add optional VRFs for simple zones Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 15/28] sdn: allow fabrics to use simple zone VRFs Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 16/28] sdn: require underlay fabrics to use the default VRF Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 17/28] sdn: move full range CIDR formats into a separate module Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 18/28] sdn: simple: support static routes in zone routing tables Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 19/28] sdn: dhcp: only configure DHCP for zones on the local node Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 20/28] sdn: dhcp: run dnsmasq in the zone VRF Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 21/28] sdn: dhcp: fix DNS server option for IPv4 subnets without gateway Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-network v3 22/28] sdn: evpn: no exit node null routes for simple zone VRFs Gabriel Goller
2026-11-19 19:41 ` [PATCH proxmox-widget-toolkit v3 23/28] ui: network: allow selecting a VRF for host interfaces Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-manager v3 24/28] ui: sdn: add VRF zone selection for fabrics Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-manager v3 25/28] network: allow setting the VRF of host interfaces Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-manager v3 26/28] ui: sdn: allow static routes for Simple zone VRFs Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-manager v3 27/28] network: generate SDN DHCP config after ifreload Gabriel Goller
2026-11-19 19:41 ` [PATCH pve-manager v3 28/28] ui: sdn: subnet: allow setting the DHCP DNS server Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119194116.575520-2-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal