From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 04DA81FF0DE for ; Thu, 19 Nov 2026 13:47:52 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7B97F216FB; Thu, 19 Nov 2026 13:47:46 +0100 (CET) From: David Riley To: pve-devel@lists.proxmox.com Subject: [PATCH pve-network v5 3/6] fix #7294: sdn: vnet: update pool members on VNet zone change and deletion Date: Thu, 19 Nov 2026 13:47:28 +0100 Message-ID: <20261119124731.84602-4-d.riley@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261119124731.84602-1-d.riley@proxmox.com> References: <20261119124731.84602-1-d.riley@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795092461628 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.903 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_DBL_SPAM 5 Contains a spam URL listed in the Spamhaus DBL blocklist [sdn.pm] Message-ID-Hash: FVG6XLDOEPNI5JBTOZNOPWHYBQXBHTKR X-Message-ID-Hash: FVG6XLDOEPNI5JBTOZNOPWHYBQXBHTKR X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When applying the SDN configuration, update user.cfg so that pool member entries for any VNet moved to another zone reflect the new zone. Additionally, remove pool entries for deleted VNets. Otherwise, pools would keep entries for VNets that no longer exist under that zone and name, and such a stale entry would grant access to a VNet created later with the same zone and name. Signed-off-by: David Riley Link: https://bugzilla.proxmox.com/show_bug.cgi?id=7294 --- src/PVE/Network/SDN.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm index 9373ec3..7a4a9e3 100644 --- a/src/PVE/Network/SDN.pm +++ b/src/PVE/Network/SDN.pm @@ -256,12 +256,18 @@ sub cleanup_access_control { if (@$vnet_move_paths) { PVE::AccessControl::migrate_sdn_resource_access($vnet_move_paths); + PVE::AccessControl::migrate_vnet_zone_in_pool($vnet_move_paths); } my @paths_to_delete = (@$vnet_delete_paths, @$route_map_paths, @$generic_paths); + if (@paths_to_delete) { PVE::AccessControl::remove_sdn_resource_access(\@paths_to_delete); } + + if (@$vnet_delete_paths) { + PVE::AccessControl::remove_vnets_from_pool($vnet_delete_paths); + } } sub diff_generic_resources { -- 2.47.3