From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id C96CC1FF0DE for ; Thu, 19 Nov 2026 12:24:14 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9440921724; Thu, 19 Nov 2026 12:24:06 +0100 (CET) From: Shannon Sterz To: pve-devel@lists.proxmox.com Subject: [PATCH cluster v2 0/2] Refine setup_sshd_config() Date: Thu, 19 Nov 2026 12:23:16 +0100 Message-ID: <20261119112318.118471-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795087440630 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.552 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LV6COOSXZSAODZNOHPMFYOM3QEY5HJ2L X-Message-ID-Hash: LV6COOSXZSAODZNOHPMFYOM3QEY5HJ2L X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: these patches allow users to set their own permissions on the sshd config and should pick up more cases in which a user may have adjusted `PermitRootLogin` in a way that could break functionality. Changelog --------- * adapt patch 2/2 to handle `Match` blocks correctly Shannon Sterz (2): cluster: setup: keep file permissions for sshd config cluster: setup: match PermitRootLogin option more precisely src/PVE/Cluster/Setup.pm | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) -- 2.47.3