From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id CF0291FF0DF for ; Thu, 19 Nov 2026 10:59:50 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5CD9B216E9; Thu, 19 Nov 2026 10:59:41 +0100 (CET) From: Dominik Rusovac To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v5 02/10] fix #6144: ui: ha: status: allow toggling maintenance mode Date: Thu, 19 Nov 2026 10:59:23 +0100 Message-ID: <20261119095931.1748970-3-d.rusovac@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261119095931.1748970-1-d.rusovac@proxmox.com> References: <20261119095931.1748970-1-d.rusovac@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795082375074 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: R7ZO7SPERJEMHUYH2JPQBYMQJ4UTGZVE X-Message-ID-Hash: R7ZO7SPERJEMHUYH2JPQBYMQJ4UTGZVE X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Thomas Skinner X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: maintenance mode could only be enabled or disabled through the HA manager's CLI add a 'Node Maintenance' menu to the HA status panel, which requests enabling/disabling maintenance mode for the node of the selected lrm entry enabling is not offered while HA is disarmed, as the CRM ignores such requests in that state. menu is disabled for users lacking the Sys.Modify privilege on nodes the LRM also enters maintenance mode on shutdown with the 'migrate' shutdown policy, which a disable request would not undo 'fa fa-check' icon was chosen for 'Disable' option to be consistent with which icon a node gets when coming back from maintenance mode Originally-by: Thomas Skinner Signed-off-by: Dominik Rusovac --- Notes: changes since v4: * rename maintenanceNode to selectedLrmNode and comment which node the other maintenance field of the view model refers to * throw on unknown maintenance modes instead of defaulting to enable * split out the spinner into a separate patch * reword commit body accordingly www/manager6/ha/Status.js | 98 +++++++++++++++++++++++++++++++++++ www/manager6/ha/StatusView.js | 4 ++ 2 files changed, 102 insertions(+) diff --git a/www/manager6/ha/Status.js b/www/manager6/ha/Status.js index c01bd737..42e9aefb 100644 --- a/www/manager6/ha/Status.js +++ b/www/manager6/ha/Status.js @@ -11,6 +11,15 @@ Ext.define('PVE.ha.Status', { viewModel: { data: { haDisarmed: false, + selectedLrmNode: null, + // maintenance state of the selected LRM node + maintenanceRequested: false, + }, + formulas: { + noMaintenanceAction: (get) => + !get('selectedLrmNode') || !Ext.state.Manager.get('GuiCap').nodes['Sys.Modify'], + // the CRM ignores requests to enable maintenance mode while HA is disarmed + noMaintenanceEnable: (get) => get('maintenanceRequested') || get('haDisarmed'), }, }, @@ -52,6 +61,65 @@ Ext.define('PVE.ha.Status', { ); }, + updateMaintenanceState: function () { + let me = this; + let vm = me.getViewModel(); + let sv = me.getView().down('pveHAStatusView'); + let rec = sv.getSelection()[0]; + let isLrm = rec?.get('type') === 'lrm'; + + vm.set('selectedLrmNode', isLrm ? rec.get('node') : null); + vm.set('maintenanceRequested', isLrm && rec.get('maintenance-requested')); + }, + + handleMaintenanceButton: function (menuItem) { + let me = this; + let node = me.getViewModel().get('selectedLrmNode'); + if (!node) { + return; + } + + let msg; + if (menuItem.maintenanceMode === 'disable') { + msg = Ext.String.format( + gettext("Are you sure you want to disable maintenance mode for node '{0}'?"), + node, + ); + if (me.getViewModel().get('haDisarmed')) { + msg += + '

' + + Ext.String.format( + gettext( + "HA resources will be migrated back to node '{0}' once HA is re-armed.", + ), + node, + ); + } + } else if (menuItem.maintenanceMode === 'enable') { + msg = Ext.String.format( + gettext("Are you sure you want to enable maintenance mode for node '{0}'?"), + node, + ); + msg += + '

' + + gettext('HA resources on the node will be migrated to other nodes.'); + } else { + throw `unknown maintenance mode '${menuItem.maintenanceMode}'`; + } + + Ext.Msg.confirm(gettext('Confirm'), msg, function (btn) { + if (btn !== 'yes') { + return; + } + Proxmox.Utils.API2Request({ + url: `/nodes/${node}/maintenance`, + params: { 'maintenance-mode': menuItem.maintenanceMode }, + method: 'PUT', + failure: (response) => Ext.Msg.alert(gettext('Error'), response.htmlStatus), + }); + }); + }, + openCRSOptions: function () { Ext.create('PVE.form.CRSOptions', { autoShow: true, @@ -121,6 +189,34 @@ Ext.define('PVE.ha.Status', { }, ], }, + '-', + { + text: gettext('Node Maintenance'), + iconCls: 'fa fa-wrench', + bind: { + disabled: '{noMaintenanceAction}', + }, + menu: [ + { + text: gettext('Enable'), + iconCls: 'fa fa-wrench', + maintenanceMode: 'enable', + bind: { + disabled: '{noMaintenanceEnable}', + }, + handler: 'handleMaintenanceButton', + }, + { + text: gettext('Disable'), + iconCls: 'fa fa-check', + maintenanceMode: 'disable', + bind: { + disabled: '{!maintenanceRequested}', + }, + handler: 'handleMaintenanceButton', + }, + ], + }, '->', { text: gettext('CRS Settings'), @@ -153,11 +249,13 @@ Ext.define('PVE.ha.Status', { collapsible: true, padding: '0 0 20 0', listeners: { + selectionchange: () => me.getController().updateMaintenanceState(), hastatuschange: function (isDisarmed) { let vm = me.getViewModel(); let sv = me.query('pveHAStatusView')[0]; vm.set('haDisarmed', isDisarmed); + me.getController().updateMaintenanceState(); if (sv.isDisarmedPendingState === null) { return; diff --git a/www/manager6/ha/StatusView.js b/www/manager6/ha/StatusView.js index f260bc0d..d08534b4 100644 --- a/www/manager6/ha/StatusView.js +++ b/www/manager6/ha/StatusView.js @@ -132,6 +132,10 @@ Ext.define( }, }, 'armed-state', + { + name: 'maintenance-requested', + type: 'boolean', + }, ], idProperty: 'id', }); -- 2.47.3