From: Jonas Theisen <j.theisen@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 04/15] cpu flags: factor out parsing the broadcast CPU flags of a node
Date: Wed, 18 Nov 2026 16:40:35 +0100 [thread overview]
Message-ID: <20261118154207.424260-5-j.theisen@proxmox.com> (raw)
In-Reply-To: <20261118154207.424260-1-j.theisen@proxmox.com>
The CPU flags that pvestatd broadcasts need to be normalized, as nodes
running an older version also broadcast aliases of some flags, for
example 'sse4_2' and 'sse4-2' in addition to 'sse4.2'.
Factor this out, so that other users of the broadcast flags cannot
forget about it.
Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
src/PVE/QemuServer/CPUFlags.pm | 21 +++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/src/PVE/QemuServer/CPUFlags.pm b/src/PVE/QemuServer/CPUFlags.pm
index 0d3206b2..0ba2e115 100644
--- a/src/PVE/QemuServer/CPUFlags.pm
+++ b/src/PVE/QemuServer/CPUFlags.pm
@@ -145,6 +145,20 @@ sub normalize_cpu_flag($flag) {
return $qemu_cpu_flag_alias_map->{$flag} // $flag;
}
+=head3 parse_node_cpu_flags($raw)
+
+Parse the CPU flags of a node, as C<pvestatd> broadcasts them in the C<cpuflags-$accel> node
+key-value entries, and return them normalized with C<normalize_cpu_flag()>.
+
+The broadcast format may differ from the current one, for example if the node runs an older
+version, which also broadcast the aliases of some flags.
+
+=cut
+
+sub parse_node_cpu_flags($raw) {
+ return map { normalize_cpu_flag($_) } split(' ', $raw);
+}
+
# Understood CPU flags are written to a file at 'pve-qemu' compile time and
# shipped below this directory by the pve-qemu-kvm package.
my $understood_cpu_flag_dir = "/usr/share/kvm";
@@ -295,12 +309,7 @@ sub query_available_cpu_flags($accel, $vm_specific, $arch) {
};
for my $node (keys %$flags) {
- # This depends on `pvestatd` storing the flags in space-separated format, which
- # is the case at the time of this commit.
- for (split(' ', $flags->{$node})) {
- # normalize as pvestatd's stored format may drift relative to the recognized
- # flag list, e.g. across upgrades or between QEMU CPUID-flag aliases.
- my $flag = normalize_cpu_flag($_);
+ for my $flag (parse_node_cpu_flags($flags->{$node})) {
my $pve_alias = undef;
$pve_alias = 'nested-virt' if $flag eq 'svm' || $flag eq 'vmx';
next if $vm_specific && !flag_is_vm_specific($flag) && !$pve_alias;
--
2.47.3
next prev parent reply other threads:[~2026-11-18 15:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 15:40 [PATCH manager/qemu-server 00/15] check the target node's CPU before live migrating a VM Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 01/15] test: migration: allow checking for warnings and errors in the log Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 02/15] migrate: block live migration of host CPU VMs between CPU vendors Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 03/15] fix #6535: migrate: warn about live migration " Jonas Theisen
2026-11-18 15:40 ` Jonas Theisen [this message]
2026-11-18 15:40 ` [PATCH qemu-server 05/15] fix #2924: migrate: block live migration of host CPU VMs to nodes lacking flags Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 06/15] migrate: warn about live migration of host CPU VMs between CPU models Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 07/15] migrate: factor out whether the running virtual CPU is kept Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 08/15] migrate: block migration if the target cannot run the kept virtual CPU Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 09/15] helpers: add helper to query the host's TSC frequency and scaling support Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 10/15] cpu config: add hv-reenlightenment flag and set TSC frequency for it Jonas Theisen
2026-11-18 15:40 ` [PATCH qemu-server 11/15] migrate: block migration to nodes with incompatible TSC for re-enlightenment Jonas Theisen
2026-11-18 15:40 ` [PATCH manager 12/15] pvestatd: broadcast host CPU information relevant for live migration Jonas Theisen
2026-11-18 15:40 ` [PATCH manager 13/15] ui: migrate: show why the CPU of the target node is incompatible Jonas Theisen
2026-11-18 15:40 ` [PATCH manager 14/15] fix #6535: ui: migrate: show CPU warnings for the target node Jonas Theisen
2026-11-18 15:40 ` [PATCH manager 15/15] api: nodes: migrateall: skip VMs whose CPU is incompatible with the target Jonas Theisen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118154207.424260-5-j.theisen@proxmox.com \
--to=j.theisen@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.