From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id EC5D71FF0C0 for ; Wed, 18 Nov 2026 16:42:45 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6E91D21804; Wed, 18 Nov 2026 16:42:42 +0100 (CET) From: Jonas Theisen To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 03/15] fix #6535: migrate: warn about live migration between CPU vendors Date: Wed, 18 Nov 2026 16:40:34 +0100 Message-ID: <20261118154207.424260-4-j.theisen@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118154207.424260-1-j.theisen@proxmox.com> References: <20261118154207.424260-1-j.theisen@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795016544834 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.089 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: A6HI4W64IWBUZO3HXGWPU7JKBH4KUOEL X-Message-ID-Hash: A6HI4W64IWBUZO3HXGWPU7JKBH4KUOEL X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Live migrating a VM between nodes with CPUs from different vendors is not guaranteed to work, even with generic CPU models that do not pass through vendor-specific features, as the CPUs still behave differently in some regards. Warn about this in the migration task, as a task warning so that the task status shows it, and report it for each node in the migration precondition API, so that it can be shown before the migration is started. As before, VMs with the 'host' or 'max' CPU model cannot be live migrated between vendors at all. Also report nodes that lack the CPU information needed for a check that would block the migration as a warning in the precondition API, as the task log only shows this once the migration is started. This is not done for other checks, to not warn about every live migration to nodes running an older version. Signed-off-by: Jonas Theisen --- src/PVE/API2/Qemu.pm | 42 +++++++++++++++++++++++++++--- src/PVE/QemuMigrate.pm | 9 ++++++- src/PVE/QemuMigrate/Helpers.pm | 19 ++++++++++++++ src/test/run_qemu_migrate_tests.pl | 33 +++++++++++++++++++++++ 4 files changed, 99 insertions(+), 4 deletions(-) diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm index 0210dd1c..9d7fcf8b 100644 --- a/src/PVE/API2/Qemu.pm +++ b/src/PVE/API2/Qemu.pm @@ -5604,6 +5604,29 @@ __PACKAGE__->register_method({ description => "Object of mapped resources with additional information such if they're live migratable.", }, + 'cpu-warnings' => { + type => 'object', + optional => 1, + description => "For each node, reasons why the VM might not run reliably on its" + . " CPU after a live migration.", + additionalProperties => { + type => 'array', + items => { + type => 'object', + properties => { + type => { + type => 'string', + description => "The check that reported the warning.", + enum => ['cpu-vendor', 'missing-cpu-info'], + }, + message => { + type => 'string', + description => "Why the VM might not run reliably.", + }, + }, + }, + }, + }, 'has-dbus-vmstate' => { type => 'boolean', description => 'Whether the VM host supports migrating additional VM state, ' @@ -5676,9 +5699,15 @@ __PACKAGE__->register_method({ my $cpu_issues_by_node = eval { my $targets = [grep { $_ ne $localnode } $nodelist->@*]; - my ($issues) = PVE::QemuMigrate::Helpers::check_target_cpu_compatibility( - $vmconf, $pid, $targets, - ); + my ($issues, $unchecked_nodes) = + PVE::QemuMigrate::Helpers::check_target_cpu_compatibility($vmconf, $pid, $targets); + my $message = "the node does not provide CPU information, for example as it runs" + . " an older version"; + for my $node ($unchecked_nodes->@*) { + my $issue = + { type => 'missing-cpu-info', severity => 'warning', message => $message }; + push $issues->{$node}->@*, $issue; + } return $issues; } // {}; warn "unable to check CPU compatibility of target nodes - $@" if $@; @@ -5705,6 +5734,13 @@ __PACKAGE__->register_method({ [map { { type => $_->{type}, message => $_->{message} } } @cpu_errors]; } + my @cpu_warnings = + grep { $_->{severity} eq 'warning' } ($cpu_issues_by_node->{$node} // [])->@*; + if (scalar(@cpu_warnings)) { + $res->{'cpu-warnings'}->{$node} = + [map { { type => $_->{type}, message => $_->{message} } } @cpu_warnings]; + } + # extracting blocking resources for current node if (my $blocking_ha_resources = $blocking_ha_resources_by_node->{$node}) { $res->{not_allowed_nodes}->{$node}->{'blocking-ha-resources'} = diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm index cf01b2eb..827f8143 100644 --- a/src/PVE/QemuMigrate.pm +++ b/src/PVE/QemuMigrate.pm @@ -322,7 +322,14 @@ sub prepare { my ($cpu_issues, $unchecked_nodes) = PVE::QemuMigrate::Helpers::check_target_cpu_compatibility($conf, $running, [$node]); - my @errors = grep { $_->{severity} eq 'error' } ($cpu_issues->{$node} // [])->@*; + my @errors; + for my $issue (($cpu_issues->{$node} // [])->@*) { + if ($issue->{severity} eq 'warning') { + log_warn("CPU of node '$node' might be incompatible: $issue->{message}"); + } else { + push @errors, $issue; + } + } if (scalar(@errors)) { die "can't migrate VM to '$node' - incompatible CPU: " . join('; ', map { $_->{message} } @errors) . "\n"; diff --git a/src/PVE/QemuMigrate/Helpers.pm b/src/PVE/QemuMigrate/Helpers.pm index f4f15b96..4e4e3ae0 100644 --- a/src/PVE/QemuMigrate/Helpers.pm +++ b/src/PVE/QemuMigrate/Helpers.pm @@ -187,6 +187,25 @@ my $target_cpu_checks = [ . " node ($source->{vendor}), but the node has $target->{vendor}"; }, }, + { + type => 'cpu-vendor', + severity => 'warning', + needs => ['vendor'], + applies => sub { + my ($cpu) = @_; + return $cpu->{kvm} && !is_host_cpu_model($cpu); + }, + check => sub { + my ($cpu, $source, $target) = @_; + + return if !vendors_differ($source, $target); + + # even generic CPU models expose behavior that differs between vendors + return + "live migration from $source->{vendor} to $target->{vendor} is not guaranteed" + . " to work, as guests can become unstable, even some time after the migration"; + }, + }, ]; # Returns the issues of the target node, and whether all checks that can prevent the migration diff --git a/src/test/run_qemu_migrate_tests.pl b/src/test/run_qemu_migrate_tests.pl index 1084123b..12ec3e90 100755 --- a/src/test/run_qemu_migrate_tests.pl +++ b/src/test/run_qemu_migrate_tests.pl @@ -1567,6 +1567,39 @@ my $tests = [ }, }, }, + { + name => '1033_running_kvm64_cpu_other_vendor', + target => 'pve1', + vmid => 1033, + vm_status => { + running => 1, + runningmachine => 'pc-q35-5.0+pve0', + runningcpu => 'kvm64,enforce,+kvm_pv_eoi,+kvm_pv_unhalt,+lahf_lm,+sep', + }, + cpu_info => { + source => { vendor => 'AuthenticAMD' }, + nodes => { + pve1 => { vendor => 'GenuineIntel' }, + }, + }, + opts => { + online => 1, + }, + expected_calls => $default_expected_calls_online, + expect_log => [ + "CPU of node 'pve1' might be incompatible: live migration from AuthenticAMD to" + . " GenuineIntel is not guaranteed to work", + ], + expected => { + source_volids => {}, + target_volids => {}, + vm_config => $vm_configs->{1033}, + vm_status => { + running => 1, + runningmachine => 'pc-q35-5.0+pve0', + }, + }, + }, { name => '105_replicated_to_non_replication_target', target => 'pve1', -- 2.47.3