From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 4A3AC1FF0C0 for ; Wed, 18 Nov 2026 16:44:37 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 36B66218F6; Wed, 18 Nov 2026 16:44:03 +0100 (CET) From: Jonas Theisen To: pve-devel@lists.proxmox.com Subject: [PATCH manager 13/15] ui: migrate: show why the CPU of the target node is incompatible Date: Wed, 18 Nov 2026 16:40:44 +0100 Message-ID: <20261118154207.424260-14-j.theisen@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118154207.424260-1-j.theisen@proxmox.com> References: <20261118154207.424260-1-j.theisen@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795016565783 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.084 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SUCWEC4YBRJYM75R2A2VDAZ7RECKXH3S X-Message-ID-Hash: SUCWEC4YBRJYM75R2A2VDAZ7RECKXH3S X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Show the reasons the migration precondition API reports for target nodes whose CPU cannot run a VM after a live migration, instead of only failing once the migration task runs. If root can override all of these reasons with migration options, offer a checkbox to ignore the incompatibility, which sets these options and shows the reasons as warnings instead. Which options to set is taken from the API, so that further overridable checks need no UI changes. The checkbox is also shown for HA-managed VMs, as the migration API forwards the override options to the HA stack. Signed-off-by: Jonas Theisen --- www/manager6/window/Migrate.js | 54 ++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js index 15ce34f8..68d93a6f 100644 --- a/www/manager6/window/Migrate.js +++ b/www/manager6/window/Migrate.js @@ -29,6 +29,8 @@ Ext.define('PVE.window.Migrate', { allowedNodes: undefined, overwriteLocalResourceCheck: false, hasLocalResources: false, + ignoreCpuIncompatibility: false, + cpuOverrides: [], withConntrackState: true, bothHaveDbusVmstate: false, configCheck: true, @@ -64,6 +66,7 @@ Ext.define('PVE.window.Migrate', { return false; } }, + cpuOverrideCheckboxHidden: (get) => !get('migration.cpuOverrides').length, conntrackStateCheckboxHidden: (get) => !get('running') || get('vmtype') !== 'qemu' || @@ -147,6 +150,12 @@ Ext.define('PVE.window.Migrate', { params.force = 1; } + if (vm.get('migration.ignoreCpuIncompatibility')) { + for (const override of vm.get('migration.cpuOverrides')) { + params[override] = 1; + } + } + if (vm.get('migration.bothHaveDbusVmstate') && vm.get('migration.withConntrackState')) { params['with-conntrack-state'] = 1; } @@ -306,6 +315,30 @@ Ext.define('PVE.window.Migrate', { migration.preconditions.push({ text, severity: 'error' }); } + let cpuBlockers = disallowed['incompatible-cpu'] ?? []; + // the override options are reserved for root + let canOverrideCpu = + Proxmox.UserName === 'root@pam' && + cpuBlockers.length > 0 && + cpuBlockers.every((blocker) => blocker.override); + migration.cpuOverrides = canOverrideCpu + ? [...new Set(cpuBlockers.map((blocker) => blocker.override))] + : []; + + for (const cpuBlocker of cpuBlockers) { + const text = Ext.String.format( + gettext('CPU of selected target is incompatible: {0}'), + cpuBlocker.message, + ); + + if (canOverrideCpu && migration.ignoreCpuIncompatibility) { + migration.preconditions.push({ text, severity: 'warning' }); + } else { + migration.possible = false; + migration.preconditions.push({ text, severity: 'error' }); + } + } + let blockingResources = []; let mappedResources = migrateStats['mapped-resource-info'] ?? {}; @@ -695,6 +728,27 @@ Ext.define('PVE.window.Migrate', { }, }, }, + { + xtype: 'proxmoxcheckbox', + name: 'ignoreCpuIncompatibility', + fieldLabel: gettext('Ignore CPU incompatibility'), + autoEl: { + tag: 'div', + 'data-qtip': gettext( + 'Migrate even if the CPU of the selected target is incompatible. The VM might crash or fail to migrate.', + ), + }, + bind: { + hidden: '{cpuOverrideCheckboxHidden}', + value: '{migration.ignoreCpuIncompatibility}', + }, + listeners: { + change: { + fn: 'checkMigratePreconditions', + extraArg: true, + }, + }, + }, { xtype: 'proxmoxcheckbox', name: 'withConntrackState', -- 2.47.3