From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id E67271FF0C0 for ; Wed, 18 Nov 2026 15:45:29 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A79642178D; Wed, 18 Nov 2026 15:45:23 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager v4 04/17] config: make update_single_resource_config_inplace only allow sids Date: Wed, 18 Nov 2026 15:44:49 +0100 Message-ID: <20261118144502.231134-5-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118144502.231134-1-d.kral@proxmox.com> References: <20261118144502.231134-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795013118857 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.492 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: M7QDF3U63O6TDC5BRKPGSZ4TPSYF4O6K X-Message-ID-Hash: M7QDF3U63O6TDC5BRKPGSZ4TPSYF4O6K X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: update_single_resource_config_inplace() has used the $sid return value from parse_sid(), though all callers already provide the SID format and do not provide the external VMID at any time. The subroutine is mainly called internally to persist the HA resource config state, e.g. when stopping an HA resource or migrating the HA groups, and is only called externally in PVE::API2::HA::Resources->update(), where the SID of a provided VMID is already determined in advance. Therefore, using the $sid return value is not needed here. Signed-off-by: Daniel Kral Reviewed-by: Michael Köppl Tested-by: Michael Köppl --- src/PVE/HA/Config.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/HA/Config.pm b/src/PVE/HA/Config.pm index 84102592..07290eee 100644 --- a/src/PVE/HA/Config.pm +++ b/src/PVE/HA/Config.pm @@ -148,7 +148,7 @@ sub read_and_check_resources_config { my sub update_single_resource_config_inplace { my ($cfg, $sid, $param, $delete) = @_; - ($sid, my $type) = parse_sid($sid); + (undef, my $type) = parse_sid($sid); my $scfg = $cfg->{ids}->{$sid} || die "no such resource '$sid'\n"; -- 2.47.3