all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server v3 8/9] migrate: log messages from remote nbdstop command
Date: Wed, 18 Nov 2026 15:27:52 +0100	[thread overview]
Message-ID: <20261118143549.199143-9-f.ebner@proxmox.com> (raw)
In-Reply-To: <20261118143549.199143-1-f.ebner@proxmox.com>

The output was always ignored since the introduction of the command in
2016 with commit b74cad8a ("add live storage migration with vm
migration"). But it's nicer to show messages from the remote side to
detect failures and for debugging purposes.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

No changes in v3.

 src/PVE/QemuMigrate.pm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm
index eb8b54b6..bca92ef3 100644
--- a/src/PVE/QemuMigrate.pm
+++ b/src/PVE/QemuMigrate.pm
@@ -1745,7 +1745,12 @@ sub phase3_cleanup {
                 my $cmd = build_ssh_command($self->{rem_ssh}, ['qm', 'nbdstop', $vmid]);
 
                 eval {
-                    PVE::Tools::run_command($cmd, outfunc => sub { }, errfunc => sub { });
+                    PVE::Tools::run_command(
+                        $cmd,
+                        logfunc => sub {
+                            $self->log('info', "[$self->{node}] $_[0]");
+                        },
+                    );
                 };
                 if (my $err = $@) {
                     $self->log('err', $err);
-- 
2.47.3





  parent reply	other threads:[~2026-11-18 14:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 14:27 [PATCH-SERIES qemu/qemu-server v3 0/9] mirror: fix regressions with blockdev and allow migration with 'ro' flag Fiona Ebner
2026-11-18 14:27 ` [PATCH qemu v3 1/9] patches/extra: allow mirror job to use non-root block node Fiona Ebner
2026-11-18 14:27 ` [PATCH qemu-server v3 2/9] partially fix #7299: fix regression with guest IO limits applying to mirror job Fiona Ebner
2026-11-18 14:27 ` [PATCH qemu-server v3 3/9] partially fix #7299: migrate: fix regression with guest IO limits applying to NBD export Fiona Ebner
2026-11-18 14:27 ` [PATCH qemu-server v3 4/9] blockdev: attach: support explicitly attaching as writeable Fiona Ebner
2026-11-18 14:27 ` [PATCH qemu-server v3 5/9] blockdev: implement reopen function Fiona Ebner
2026-11-18 14:27 ` [PATCH qemu-server v3 6/9] partially fix #7836: allow mirror for drive with read-only flag when using blockdev Fiona Ebner
2026-11-18 14:27 ` [PATCH qemu-server v3 7/9] qm: schema: declare 'nbdstop' command as being for internal use only Fiona Ebner
2026-11-18 14:27 ` Fiona Ebner [this message]
2026-11-18 14:27 ` [PATCH qemu-server v3 9/9] partially fix #7836: allow migration for drive with read-only flag when using blockdev Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118143549.199143-9-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal