From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id A9FBE1FF0C0 for ; Wed, 18 Nov 2026 15:27:32 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3FB1721854; Wed, 18 Nov 2026 15:26:18 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager v3 10/17] lrm: rename update_lrm_status to flush_lrm_status Date: Wed, 18 Nov 2026 15:25:49 +0100 Message-ID: <20261118142556.218589-11-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118142556.218589-1-d.kral@proxmox.com> References: <20261118142556.218589-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795011969724 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.521 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MKDPZHOZBG6LHGMQX5W7QIOWDUTOFE45 X-Message-ID-Hash: MKDPZHOZBG6LHGMQX5W7QIOWDUTOFE45 X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Make the method name similar to PVE::HA::Manager::flush_manager_status as the term "flush" is more telling about the method writing something out than the term "update" which could be an update in any direction. Signed-off-by: Daniel Kral Reviewed-by: Michael Köppl Tested-by: Michael Köppl --- src/PVE/HA/LRM.pm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm index d09316dd..36e41ff4 100644 --- a/src/PVE/HA/LRM.pm +++ b/src/PVE/HA/LRM.pm @@ -149,7 +149,7 @@ sub shutdown_request { $self->{shutdown_request} = $haenv->get_time(); - eval { $self->update_lrm_status() or die "not quorate?\n"; }; + eval { $self->flush_lrm_status() or die "not quorate?\n"; }; if (my $err = $@) { $haenv->log('err', "unable to update lrm status file - $err"); } @@ -180,7 +180,7 @@ sub set_local_status { $self->{status} = $new; } -sub update_lrm_status { +sub flush_lrm_status { my ($self) = @_; my $haenv = $self->{haenv}; @@ -359,7 +359,7 @@ sub work { my $haenv = $self->{haenv}; if (!$wrote_lrm_status_at_startup) { - if ($self->update_lrm_status()) { + if ($self->flush_lrm_status()) { $wrote_lrm_status_at_startup = 1; } else { # do nothing @@ -484,7 +484,7 @@ sub work { return 0 if $self->{shutdown_request}; - $self->update_lrm_status(); + $self->flush_lrm_status(); $haenv->sleep(5); @@ -552,7 +552,7 @@ sub work { $haenv->log('err', "got unexpected error - $err"); } - $self->update_lrm_status(); + $self->flush_lrm_status(); return 0 if $shutdown; @@ -630,7 +630,7 @@ sub work { $haenv->log('err', "got unexpected error - $err"); } - $self->update_lrm_status(); + $self->flush_lrm_status(); return 0 if $exit_lrm; -- 2.47.3