From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id AD70F1FF0C0 for ; Wed, 18 Nov 2026 14:30:07 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 158D2216E3; Wed, 18 Nov 2026 14:29:58 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH v2 manager 05/20] vzdump: drop never-set fallback for the lock wait time Date: Wed, 18 Nov 2026 14:18:29 +0100 Message-ID: <20261118132947.1093069-6-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118132947.1093069-1-t.lamprecht@proxmox.com> References: <20261118132947.1093069-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795008592305 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.174 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 33GCBX2N2L5SSOAZECRXQ7LHU7ISUZUK X-Message-ID-Hash: 33GCBX2N2L5SSOAZECRXQ7LHU7ISUZUK X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The lock wait time falls back to a value stored on the object, but nothing has ever set one there since vzdump moved into this package. The option always has a value anyway, as the constructor fills in the configured or default one. No semantic change intended. Signed-off-by: Thomas Lamprecht --- new in v2 [Fiona] PVE/VZDump.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index d2861f9e7..48d2541c9 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -761,7 +761,7 @@ sub getlock { my $fh; - my $maxwait = $self->{opts}->{lockwait} || $self->{lockwait}; + my $maxwait = $self->{opts}->{lockwait}; die "missing UPID" if !$upid; # should not happen -- 2.47.3